2010-02-04 12:48:21

by Nikanth Karthikesan

Subject: [PATCH] define percpu_counter_batch when CONFIG_SMP is not set

percpu_counter_batch is not defined if CONFIG_SMP is not set.

Signed-off-by: Nikanth Karthikesan <[email protected]>

---

diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h
index a7684a5..ff57cef 100644
--- a/include/linux/percpu_counter.h
+++ b/include/linux/percpu_counter.h
@@ -83,6 +83,8 @@ struct percpu_counter {
s64 count;
};

+#define percpu_counter_batch 2
+
static inline int percpu_counter_init(struct percpu_counter *fbc, s64 amount)
{
fbc->count = amount;

2010-02-04 12:57:31

by Nikanth Karthikesan

Subject: Re: [PATCH] define percpu_counter_batch when CONFIG_SMP is not set

On Thursday 04 February 2010 18:19:22 Nikanth Karthikesan wrote:
> percpu_counter_batch is not defined if CONFIG_SMP is not set.

The patch "sched: cpuacct: Use bigger percpu counter batch values for stats
counters" in tip (43f85eab1411905afe5db510fbf9841b516e7e6a) would fail to
build without this if CONFIG_SMP is not set.

Thanks
Nikanth

2010-02-04 15:03:59

by Peter Zijlstra

Subject: Re: [PATCH] define percpu_counter_batch when CONFIG_SMP is not set

On Thu, 2010-02-04 at 18:28 +0530, Nikanth Karthikesan wrote:
> On Thursday 04 February 2010 18:19:22 Nikanth Karthikesan wrote:
> > percpu_counter_batch is not defined if CONFIG_SMP is not set.
>
> The patch "sched: cpuacct: Use bigger percpu counter batch values for stats
> counters" in tip (43f85eab1411905afe5db510fbf9841b516e7e6a) would fail to
> build without this if CONFIG_SMP is not set.

Which is why it got reverted (e2dfc8a0356ee7e065bd5ec8a2ca0f9b61c2daef),
Anton also posted a new version that actually does build on UP.