Hi all!
As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.
LWMON5 is a larger chunk from the kategory unreachable and
here for ever. Seems this board was either only available from
external trees or has been removed a long time ago. If you agree it
might be worth removing it.
Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.
Regards
Christoph Egger
[0] http://vamos1.informatik.uni-erlangen.de/
----
>From 8334822cc79b4cf0b7f6844ebd952ebb24ee046f Mon Sep 17 00:00:00 2001
From: Christoph Egger <[email protected]>
Date: Fri, 5 Feb 2010 13:49:13 +0100
Subject: [PATCH] Remove conditionalizing on LWMON5
There was some condigionalizing for the LWMON5 boards in kernel
source. However infrastructure for enabling this isn't here so
probably the special case code can go as well.
Signed-off-by: Christoph Egger <[email protected]>
---
drivers/video/mb862xx/mb862xxfb.c | 13 -------------
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/drivers/video/mb862xx/mb862xxfb.c b/drivers/video/mb862xx/mb862xxfb.c
index fabb0c5..8280a58 100644
--- a/drivers/video/mb862xx/mb862xxfb.c
+++ b/drivers/video/mb862xx/mb862xxfb.c
@@ -31,15 +31,6 @@
#define CARMINE_MEM_SIZE 0x8000000
#define DRV_NAME "mb862xxfb"
-#if defined(CONFIG_LWMON5)
-static struct mb862xx_gc_mode lwmon5_gc_mode = {
- /* Mode for Sharp LQ104V1DG61 TFT LCD Panel */
- { "640x480", 60, 640, 480, 40000, 48, 16, 32, 11, 96, 2, 0, 0, 0 },
- /* 16 bits/pixel, 32MB, 100MHz, SDRAM memory mode value */
- 16, 0x2000000, GC_CCF_COT_100, 0x414fb7f2
-};
-#endif
-
#if defined(CONFIG_SOCRATES)
static struct mb862xx_gc_mode socrates_gc_mode = {
/* Mode for Prime View PM070WL4 TFT LCD Panel */
@@ -600,10 +591,6 @@ static int __devinit of_platform_mb862xx_probe(struct of_device *ofdev,
goto irqdisp;
}
-#if defined(CONFIG_LWMON5)
- par->gc_mode = &lwmon5_gc_mode;
-#endif
-
#if defined(CONFIG_SOCRATES)
par->gc_mode = &socrates_gc_mode;
#endif
--
1.6.3.3
On Fri, Feb 05, 2010 at 02:42:57 +0100, Christoph Egger wrote:
> Hi all!
Hi,
(adding Valentin's actual address to the loop)
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> LWMON5 is a larger chunk from the kategory unreachable and
> here for ever. Seems this board was either only available from
> external trees or has been removed a long time ago. If you agree it
> might be worth removing it.
>
> Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.
>
> Regards
>
> Christoph Egger
>
> [0] http://vamos1.informatik.uni-erlangen.de/
>
> ----
> From 8334822cc79b4cf0b7f6844ebd952ebb24ee046f Mon Sep 17 00:00:00 2001
> From: Christoph Egger <[email protected]>
> Date: Fri, 5 Feb 2010 13:49:13 +0100
> Subject: [PATCH] Remove conditionalizing on LWMON5
>
> There was some condigionalizing for the LWMON5 boards in kernel
> source. However infrastructure for enabling this isn't here so
> probably the special case code can go as well.
>
> Signed-off-by: Christoph Egger <[email protected]>
Acked-by: Alexander Shishkin <[email protected]>
Regards,
--
Alex
On Fri, 5 Feb 2010 14:42:57 +0100
Christoph Egger <[email protected]> wrote:
> LWMON5 is a larger chunk from the kategory unreachable and
> here for ever. Seems this board was either only available from
> external trees or has been removed a long time ago. If you agree it
> might be worth removing it.
The LWMON5 board port existed for arch/ppc which was removed
entirely in 2.6.27. So, it is ok to apply this patch.
> ----
> From 8334822cc79b4cf0b7f6844ebd952ebb24ee046f Mon Sep 17 00:00:00 2001
> From: Christoph Egger <[email protected]>
> Date: Fri, 5 Feb 2010 13:49:13 +0100
> Subject: [PATCH] Remove conditionalizing on LWMON5
>
> There was some condigionalizing for the LWMON5 boards in kernel
> source. However infrastructure for enabling this isn't here so
> probably the special case code can go as well.
>
> Signed-off-by: Christoph Egger <[email protected]>
Acked-by: Anatolij Gustschin <[email protected]>