2010-02-16 08:59:57

by Alexander Schmidt

Subject: [PATCH] ib/ehca: fix in_wc handling in process_mad()

If the caller does not pass a valid in_wc to process_mad(),
return MAD failure as it is not possible to generate a valid
MAD redirect response.

Signed-off-by: Alexander Schmidt <[email protected]>
---

Hi Roland,

this is another patch we would like to get in your next tree for
2.6.34.

drivers/infiniband/hw/ehca/ehca_sqp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.orig/drivers/infiniband/hw/ehca/ehca_sqp.c
+++ linux-2.6/drivers/infiniband/hw/ehca/ehca_sqp.c
@@ -222,7 +222,7 @@ int ehca_process_mad(struct ib_device *i
{
int ret;

- if (!port_num || port_num > ibdev->phys_port_cnt)
+ if (!port_num || port_num > ibdev->phys_port_cnt || !in_wc)
return IB_MAD_RESULT_FAILURE;

/* accept only pma request */

2010-02-19 19:14:11

by Roland Dreier

Subject: Re: [PATCH] ib/ehca: fix in_wc handling in process_mad()

thanks, applied.
--
Roland Dreier <[email protected]>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html