2010-02-20 14:12:52

by Dave Young

Subject: [PATCH 06/18] sysctl extern cleanup - mm

Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.

Move min_free_kbytes extern declaration to linux/mm.h

Signed-off-by: Dave Young <[email protected]>
---
include/linux/mm.h | 1 +
kernel/sysctl.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.32.orig/include/linux/mm.h 2010-02-20 14:02:25.281592573 +0800
+++ linux-2.6.32/include/linux/mm.h 2010-02-20 14:14:21.374855298 +0800
@@ -31,6 +31,7 @@ extern int page_cluster;

#ifdef CONFIG_SYSCTL
extern int sysctl_legacy_va_layout;
+extern int min_free_kbytes;
#else
#define sysctl_legacy_va_layout 0
#endif
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-20 14:13:08.415694935 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-20 14:13:28.511525875 +0800
@@ -72,7 +72,6 @@
#if defined(CONFIG_SYSCTL)

/* External variables not in a header file. */
-extern int min_free_kbytes;
extern int compat_log;
extern int latencytop_enabled;
extern int sysctl_nr_open_min, sysctl_nr_open_max;

2010-02-21 00:58:15

by David Rientjes

Subject: Re: [PATCH 06/18] sysctl extern cleanup - mm

On Sat, 20 Feb 2010, Dave Young wrote:

> Extern declarations in sysctl.c should be move to their own head file,
> and then include them in relavant .c files.
>
> Move min_free_kbytes extern declaration to linux/mm.h
>

It should be moved to include/linux/mmzone.h, that's where the sysctl
handler is declared.