2010-02-20 14:16:31

by Dave Young

Subject: [PATCH 10/18] sysctl extern cleanup - rcu

Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.

Move rcutorture_runnable extern declaration to linux/rcupdate.h

Signed-off-by: Dave Young <[email protected]>
---
include/linux/rcupdate.h | 6 ++++++
kernel/sysctl.c | 3 ---
2 files changed, 6 insertions(+), 3 deletions(-)

--- linux-2.6.32.orig/include/linux/rcupdate.h 2010-02-20 14:02:21.664925977 +0800
+++ linux-2.6.32/include/linux/rcupdate.h 2010-02-20 14:21:31.394811788 +0800
@@ -41,6 +41,12 @@
#include <linux/lockdep.h>
#include <linux/completion.h>

+#ifdef CONFIG_SYSCTL
+#ifdef CONFIG_RCU_TORTURE_TEST
+extern int rcutorture_runnable;
+#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
+#endif
+
/**
* struct rcu_head - callback structure for use with RCU
* @next: next update requests in a list
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-20 14:18:05.088997885 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-20 14:20:08.432318998 +0800
@@ -75,9 +75,6 @@
#if defined(CONFIG_SYSCTL)

/* External variables not in a header file. */
-#ifdef CONFIG_RCU_TORTURE_TEST
-extern int rcutorture_runnable;
-#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
#ifdef CONFIG_BLOCK
extern int blk_iopoll_enabled;
#endif

2010-02-20 20:44:39

by Josh Triplett

Subject: Re: [PATCH 10/18] sysctl extern cleanup - rcu

On Sat, Feb 20, 2010 at 10:16:20PM +0800, Dave Young wrote:
> Extern declarations in sysctl.c should be move to their own head file,
> and then include them in relavant .c files.
>
> Move rcutorture_runnable extern declaration to linux/rcupdate.h
>
> Signed-off-by: Dave Young <[email protected]>

Acked-by: Josh Triplett <[email protected]>

That said, this could probably become something other than a sysctl
easily enough; debugfs or writable module parameters come to mind.

- Josh Triplett