2010-02-22 20:42:45

by Valerie Aurora

[permalink] [raw]
Subject: [PATCH] VFS: BUG_ON() rehash of an already hashed dentry

This is a one-line debugging patch which is invaluable when working on
the dcache. Can I get a yea or a nay on this so I can drop it if it
will never go in? Thanks,

-VAL

From: Jan Blunck <[email protected]>
Date: Sun, 17 May 2009 17:29:47 -0700

BUG_ON() rehash of an already hashed dentry. For debugging of
dcache-related development.

Signed-off-by: Jan Blunck <[email protected]>
Signed-off-by: Valerie Aurora <[email protected]>
Cc: Alexander Viro <[email protected]>
---
fs/dcache.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index 74da947..3d656ab 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1568,6 +1568,7 @@ void d_rehash(struct dentry * entry)
{
spin_lock(&dcache_lock);
spin_lock(&entry->d_lock);
+ BUG_ON(!d_unhashed(entry));
_d_rehash(entry);
spin_unlock(&entry->d_lock);
spin_unlock(&dcache_lock);
--
1.5.6.5