Hi,
> From: Mark Langsdorf <[email protected]>
>
> Starting with model 10 of Family 0x10, AMD processors may have
> support for APERF/MPERF. Add support for identifying it and using
> it within cpufreq. Move the APERF/MPERF functions out of the
> acpi-cpufreq code and into their own file so they can easily be
> shared.
just out of interest: what are the realnames of these processors (>= Mangy-Core) ?
> Signed-off-by: Mark Langsdorf <[email protected]>
> Signed-off-by: Borislav Petkov <[email protected]>
> Reviewed-by: Thomas Renninger <[email protected]>
> ---
> arch/x86/kernel/cpu/cpufreq/Makefile | 4 +-
> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 44 +-----------------------
> arch/x86/kernel/cpu/cpufreq/mperf.c | 50
> ++++++++++++++++++++++++++++ arch/x86/kernel/cpu/cpufreq/mperf.h |
> 9 +++++
> arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 8 ++++
> 5 files changed, 71 insertions(+), 44 deletions(-)
> create mode 100644 arch/x86/kernel/cpu/cpufreq/mperf.c
this file has no copyright or module license, thus tainting my kernel...
> create mode 100644 arch/x86/kernel/cpu/cpufreq/mperf.h
>
Marvin
From: Marvin <[email protected]>
Date: Thu, Apr 01, 2010 at 11:01:04AM +0200
> > From: Mark Langsdorf <[email protected]>
> >
> > Starting with model 10 of Family 0x10, AMD processors may have
> > support for APERF/MPERF. Add support for identifying it and using
> > it within cpufreq. Move the APERF/MPERF functions out of the
> > acpi-cpufreq code and into their own file so they can easily be
> > shared.
>
> just out of interest: what are the realnames of these processors (>= Mangy-Core) ?
Well, you're going to have to wait and see. Or search the net :)
> > Signed-off-by: Mark Langsdorf <[email protected]>
> > Signed-off-by: Borislav Petkov <[email protected]>
> > Reviewed-by: Thomas Renninger <[email protected]>
> > ---
> > arch/x86/kernel/cpu/cpufreq/Makefile | 4 +-
> > arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 44 +-----------------------
> > arch/x86/kernel/cpu/cpufreq/mperf.c | 50
> > ++++++++++++++++++++++++++++ arch/x86/kernel/cpu/cpufreq/mperf.h |
> > 9 +++++
> > arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 8 ++++
> > 5 files changed, 71 insertions(+), 44 deletions(-)
> > create mode 100644 arch/x86/kernel/cpu/cpufreq/mperf.c
>
> this file has no copyright or module license, thus tainting my kernel...
This is not a standalone module but only an auxiliary. How does that
taint your kernel? dmesg, .config please.
--
Regards/Gruss,
Boris.
--
Advanced Micro Devices, Inc.
Operating Systems Research Center
> From: Marvin <[email protected]>
> Date: Thu, Apr 01, 2010 at 11:01:04AM +0200
>
> > > From: Mark Langsdorf <[email protected]>
> > >
> > > Starting with model 10 of Family 0x10, AMD processors may have
> > > support for APERF/MPERF. Add support for identifying it and using
> > > it within cpufreq. Move the APERF/MPERF functions out of the
> > > acpi-cpufreq code and into their own file so they can easily be
> > > shared.
> >
> > just out of interest: what are the realnames of these processors (>=
> > Mangy-Core) ?
>
> Well, you're going to have to wait and see. Or search the net :)
ok - I take this as "not yet".
>
> > > Signed-off-by: Mark Langsdorf <[email protected]>
> > > Signed-off-by: Borislav Petkov <[email protected]>
> > > Reviewed-by: Thomas Renninger <[email protected]>
> > > ---
> > >
> > > arch/x86/kernel/cpu/cpufreq/Makefile | 4 +-
> > > arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 44
> > > +----------------------- arch/x86/kernel/cpu/cpufreq/mperf.c |
> > > 50
> > >
> > > ++++++++++++++++++++++++++++ arch/x86/kernel/cpu/cpufreq/mperf.h
> > > |
> > >
> > > 9 +++++
> > >
> > > arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 8 ++++
> > > 5 files changed, 71 insertions(+), 44 deletions(-)
> > > create mode 100644 arch/x86/kernel/cpu/cpufreq/mperf.c
> >
> > this file has no copyright or module license, thus tainting my kernel...
>
> This is not a standalone module but only an auxiliary. How does that
> taint your kernel? dmesg, .config please.
I think compiling powernow_k8 as a module is sufficient.
# lsmod | grep powernow
powernow_k8 16595 1
mperf 1379 1 powernow_k8
processor 39129 1 powernow_k8
# dmesg | grep -B5 powernow
[ 11.676876] ip6_tables: (C) 2000-2006 Netfilter Core Team
[ 12.005031] ip_tables: (C) 2000-2006 Netfilter Core Team
[ 12.051995] nf_conntrack version 0.5.0 (16384 buckets, 65536 max)
[ 12.096556] mperf: module license 'unspecified' taints kernel.
[ 12.097906] Disabling lock debugging due to kernel taint
[ 12.117403] powernow-k8: Found 1 AMD Phenom(tm) II X4 B55 Processor (4 cpu cores)
(version 2.20.00)
[ 12.118714] powernow-k8: 0 : pstate 0 (3200 MHz)
[ 12.120063] powernow-k8: 1 : pstate 1 (2500 MHz)
[ 12.121389] powernow-k8: 2 : pstate 2 (2100 MHz)
[ 12.122713] powernow-k8: 3 : pstate 3 (800 MHz)
Marvin
From: Marvin <[email protected]>
Date: Thu, Apr 01, 2010 at 01:46:10PM +0200
Yep, I could reproduce it, thanks for reporting.
> I think compiling powernow_k8 as a module is sufficient.
Almost, you need acpi-cpufreq (CONFIG_X86_ACPI_CPUFREQ) also as module
so that mperf.ko gets compiled as a module too since its being shared
between the two. Otherwise it is statically linked into whichever of the
two (apci-cpufreq or powernow-k8) are built-in.
Fix follows.
--
Regards/Gruss,
Boris.
--
Advanced Micro Devices, Inc.
Operating Systems Research Center