2010-04-02 10:40:51

by Li Hong

Subject: [PATCH] nilfs2: Remove an uninitialization warning in nilfs_btree_propagate_v()

`make CONFIG_NILFS2_FS=m M=fs/nilfs2/` will give the following warnings:

fs/nilfs2/btree.c: In function ‘nilfs_btree_propagate’:
fs/nilfs2/btree.c:1882: warning: ‘maxlevel’ may be used uninitialized in this function
fs/nilfs2/btree.c:1882: note: ‘maxlevel’ was declared here

Set maxlevel = 0 to fix it.

Signed-off-by: Li Hong <[email protected]>
---
fs/nilfs2/btree.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
index 7cdd98b..76c38e3 100644
--- a/fs/nilfs2/btree.c
+++ b/fs/nilfs2/btree.c
@@ -1879,7 +1879,7 @@ static int nilfs_btree_propagate_v(struct nilfs_btree *btree,
struct nilfs_btree_path *path,
int level, struct buffer_head *bh)
{
- int maxlevel, ret;
+ int maxlevel = 0, ret;
struct nilfs_btree_node *parent;
struct inode *dat = nilfs_bmap_get_dat(&btree->bt_bmap);
__u64 ptr;
--
1.6.3.3

2010-04-02 11:09:35

by Ryusuke Konishi

Subject: Re: [PATCH] nilfs2: Remove an uninitialization warning in nilfs_btree_propagate_v()

On Fri, 2 Apr 2010 18:40:39 +0800, Li Hong <[email protected]> wrote:
> `make CONFIG_NILFS2_FS=m M=fs/nilfs2/` will give the following warnings:
>
> fs/nilfs2/btree.c: In function $B!F(Bnilfs_btree_propagate$B!G(B:
> fs/nilfs2/btree.c:1882: warning: $B!F(Bmaxlevel$B!G(B may be used uninitialized in this function
> fs/nilfs2/btree.c:1882: note: $B!F(Bmaxlevel$B!G(B was declared here
>
> Set maxlevel = 0 to fix it.
>
> Signed-off-by: Li Hong <[email protected]>

Applied, thanks.

Ryusuke Konishi

> ---
> fs/nilfs2/btree.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
> index 7cdd98b..76c38e3 100644
> --- a/fs/nilfs2/btree.c
> +++ b/fs/nilfs2/btree.c
> @@ -1879,7 +1879,7 @@ static int nilfs_btree_propagate_v(struct nilfs_btree *btree,
> struct nilfs_btree_path *path,
> int level, struct buffer_head *bh)
> {
> - int maxlevel, ret;
> + int maxlevel = 0, ret;
> struct nilfs_btree_node *parent;
> struct inode *dat = nilfs_bmap_get_dat(&btree->bt_bmap);
> __u64 ptr;
> --
> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/