2010-04-08 03:12:55

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the drm tree

Hi Dave,

After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/gpu/drm/ttm/ttm_page_alloc.c: In function 'ttm_page_pool_free':
drivers/gpu/drm/ttm/ttm_page_alloc.c:311: error: implicit declaration of function 'kmalloc'
drivers/gpu/drm/ttm/ttm_page_alloc.c:312: warning: assignment makes pointer from integer without a cast
drivers/gpu/drm/ttm/ttm_page_alloc.c:375: error: implicit declaration of function 'kfree'
drivers/gpu/drm/ttm/ttm_page_alloc.c: In function 'ttm_alloc_new_pages':
drivers/gpu/drm/ttm/ttm_page_alloc.c:483: warning: assignment makes pointer from integer without a cast

Caused by commit 1403b1a38e8b19a4cc17e2c158e278628943a436 ("drm/ttm: add
pool wc/uc page allocator V3") interacting with the removal of slab.h
from percpu.h.

I applied the following patch for today.

From: Stephen Rothwell <[email protected]>
Date: Thu, 8 Apr 2010 13:05:05 +1000
Subject: [PATCH] drm/ttm: using kmalloc/kfree requires including slab.h

Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/gpu/drm/ttm/ttm_page_alloc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c
index 6ca9b27..d6c40bd 100644
--- a/drivers/gpu/drm/ttm/ttm_page_alloc.c
+++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c
@@ -36,6 +36,7 @@
#include <linux/mm_types.h>
#include <linux/module.h>
#include <linux/mm.h>
+#include <linux/slab.h>

#include <asm/atomic.h>
#include <asm/agp.h>
--
1.7.0.4

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


2010-04-08 03:53:06

by Dave Airlie

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the drm tree

> After merging the drm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/gpu/drm/ttm/ttm_page_alloc.c: In function 'ttm_page_pool_free':
> drivers/gpu/drm/ttm/ttm_page_alloc.c:311: error: implicit declaration of function 'kmalloc'
> drivers/gpu/drm/ttm/ttm_page_alloc.c:312: warning: assignment makes pointer from integer without a cast
> drivers/gpu/drm/ttm/ttm_page_alloc.c:375: error: implicit declaration of function 'kfree'
> drivers/gpu/drm/ttm/ttm_page_alloc.c: In function 'ttm_alloc_new_pages':
> drivers/gpu/drm/ttm/ttm_page_alloc.c:483: warning: assignment makes pointer from integer without a cast
>
> Caused by commit 1403b1a38e8b19a4cc17e2c158e278628943a436 ("drm/ttm: add
> pool wc/uc page allocator V3") interacting with the removal of slab.h
> from percpu.h.
>
> I applied the following patch for today.

Thanks Stephen,

applied for next drm-next.

Dave.

2010-04-08 04:14:32

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the drm tree

Hi Dave,

On Thu, 8 Apr 2010 04:52:44 +0100 (IST) Dave Airlie <[email protected]> wrote:
>
> applied for next drm-next.

Thanks.

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

Attachments:
(No filename) (232.00 B)
 (No filename) (198.00 B)
 Download all attachments

2010-04-08 16:19:06

by Tony Luck

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the drm tree

Does anyone else see:

drivers/gpu/drm/ttm/ttm_page_alloc.c: In function ?ttm_page_alloc_debugfs?:
drivers/gpu/drm/ttm/ttm_page_alloc.c:830: error: implicit declaration
of function ?seq_printf?

when building the next-20100408 tag?

-Tony

2010-04-08 20:50:32

by Pauli Nieminen

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the drm tree

On Thu, Apr 8, 2010 at 7:19 PM, Tony Luck <[email protected]> wrote:
> Does anyone else see:
>
> drivers/gpu/drm/ttm/ttm_page_alloc.c: In function ?ttm_page_alloc_debugfs?:
> drivers/gpu/drm/ttm/ttm_page_alloc.c:830: error: implicit declaration
> of function ?seq_printf?
>
> when building the next-20100408 tag?
>
> -Tony
>

http://marc.info/?l=dri-devel&m=127067975811418&w=2