2010-04-13 19:05:34

by Dinh.Nguyen

Subject: [PATCH 2.6.34-rc4 1/1] mx5: Fix build error for mx51_defconfig

From: Dinh Nguyen <[email protected]>

Need to include <asm/div64.h> for do_div calls.

Signed-off-by: Dinh Nguyen <[email protected]>
---
arch/arm/mach-mx5/clock-mx51.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-mx5/clock-mx51.c b/arch/arm/mach-mx5/clock-mx51.c
index 8f85f73..1ee6ce4 100644
--- a/arch/arm/mach-mx5/clock-mx51.c
+++ b/arch/arm/mach-mx5/clock-mx51.c
@@ -16,6 +16,7 @@
#include <linux/io.h>

#include <asm/clkdev.h>
+#include <asm/div64.h>

#include <mach/hardware.h>
#include <mach/common.h>
--
1.6.0.4

2010-04-14 06:44:45

by Amit Kucheria

Subject: Re: [PATCH 2.6.34-rc4 1/1] mx5: Fix build error for mx51_defconfig

On 10 Apr 13, [email protected] wrote:
> From: Dinh Nguyen <[email protected]>
>
> Need to include <asm/div64.h> for do_div calls.
>
> Signed-off-by: Dinh Nguyen <[email protected]>
> ---
> arch/arm/mach-mx5/clock-mx51.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mx5/clock-mx51.c b/arch/arm/mach-mx5/clock-mx51.c
> index 8f85f73..1ee6ce4 100644
> --- a/arch/arm/mach-mx5/clock-mx51.c
> +++ b/arch/arm/mach-mx5/clock-mx51.c
> @@ -16,6 +16,7 @@
> #include <linux/io.h>
>
> #include <asm/clkdev.h>
> +#include <asm/div64.h>
>
> #include <mach/hardware.h>
> #include <mach/common.h>
> --
> 1.6.0.4

Acked-by: Amit Kucheria <[email protected]>

Sascha, I can collect all the mx5 patches and make them available to you in a
git pull-request. Would that be ok?

Regards,
Amit
p.s. Your patches are on my todo list. Will get to them now.

--
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || [email protected]
----------------------------------------------------------------------

2010-04-14 06:54:45

by Sascha Hauer

Subject: Re: [PATCH 2.6.34-rc4 1/1] mx5: Fix build error for mx51_defconfig

On Wed, Apr 14, 2010 at 09:44:37AM +0300, Amit Kucheria wrote:
> On 10 Apr 13, [email protected] wrote:
> > From: Dinh Nguyen <[email protected]>
> >
> > Need to include <asm/div64.h> for do_div calls.
> >
> > Signed-off-by: Dinh Nguyen <[email protected]>
> > ---
> > arch/arm/mach-mx5/clock-mx51.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-mx5/clock-mx51.c b/arch/arm/mach-mx5/clock-mx51.c
> > index 8f85f73..1ee6ce4 100644
> > --- a/arch/arm/mach-mx5/clock-mx51.c
> > +++ b/arch/arm/mach-mx5/clock-mx51.c
> > @@ -16,6 +16,7 @@
> > #include <linux/io.h>
> >
> > #include <asm/clkdev.h>
> > +#include <asm/div64.h>
> >
> > #include <mach/hardware.h>
> > #include <mach/common.h>
> > --
> > 1.6.0.4
>
> Acked-by: Amit Kucheria <[email protected]>
>
> Sascha, I can collect all the mx5 patches and make them available to you in a
> git pull-request. Would that be ok?

I prefer collecting them myself since many patches will be not i.MX51
specific but i.MX specific and I'm afraid of too many merge conflicts.

>
> Regards,
> Amit
> p.s. Your patches are on my todo list. Will get to them now.

They are already mainline.

Sascha


--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |