Subject: Re: [PATCH] oprofile: remove double ring buffering

On 01.04.10 03:17:25, Andi Kleen wrote:
> Got confirmation now this patch fixes most of the dropped oprofile
> samples problem on a particular intensive test on a large system.
> So now submitting the previous RFC formally.
> .34 / Stable candidate.

Thanks Andi, will take a look at this next week.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]


2010-04-01 19:11:31

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] oprofile: remove double ring buffering

On Thu, 2010-04-01 at 21:02 +0200, Robert Richter wrote:
> On 01.04.10 03:17:25, Andi Kleen wrote:
> > Got confirmation now this patch fixes most of the dropped oprofile
> > samples problem on a particular intensive test on a large system.
> > So now submitting the previous RFC formally.
> > .34 / Stable candidate.
>
> Thanks Andi, will take a look at this next week.

Note, I just sent out a patch set yesterday which will conflict with
this change.

I Cc'd both you and Andi on that patch.

-- Steve

2010-04-04 10:01:18

by Andi Kleen

[permalink] [raw]
Subject: Re: [PATCH] oprofile: remove double ring buffering

On Thu, Apr 01, 2010 at 03:11:24PM -0400, Steven Rostedt wrote:
> On Thu, 2010-04-01 at 21:02 +0200, Robert Richter wrote:
> > On 01.04.10 03:17:25, Andi Kleen wrote:
> > > Got confirmation now this patch fixes most of the dropped oprofile
> > > samples problem on a particular intensive test on a large system.
> > > So now submitting the previous RFC formally.
> > > .34 / Stable candidate.
> >
> > Thanks Andi, will take a look at this next week.
>
> Note, I just sent out a patch set yesterday which will conflict with
> this change.
>
> I Cc'd both you and Andi on that patch.

Steve, is your ring buffer patch intended for stable?

I plan to submit the oprofile patch for stable and if your is not
it would be more convenient if your patch was based on mine instead
of the other way round. If yours is for stable I can rebase on top
of yours.

Thanks,

-Andi
--
[email protected] -- Speaking for myself only.

2010-04-04 13:07:46

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] oprofile: remove double ring buffering

On Sun, 2010-04-04 at 12:01 +0200, Andi Kleen wrote:

> > Note, I just sent out a patch set yesterday which will conflict with
> > this change.
> >
> > I Cc'd both you and Andi on that patch.
>
> Steve, is your ring buffer patch intended for stable?
>
> I plan to submit the oprofile patch for stable and if your is not
> it would be more convenient if your patch was based on mine instead
> of the other way round. If yours is for stable I can rebase on top
> of yours.

No, my patch is not intended for stable, and in fact, is intended for
35.

When yours gets into Linus's tree, we can fix the conflict. It should be
trivial to fix, since the conflict is just me adding another parameter
(NULL) to a function you changed.

I just wanted you to be aware of the change, you don't need to do
anything about it.

-- Steve



2010-04-22 14:33:59

by John Villalovos

[permalink] [raw]
Subject: Re: [PATCH] oprofile: remove double ring buffering

On Thu, Apr 1, 2010 at 3:02 PM, Robert Richter <[email protected]> wrote:
> On 01.04.10 03:17:25, Andi Kleen wrote:
>> Got confirmation now this patch fixes most of the dropped oprofile
>> samples problem on a particular intensive test on a large system.
>> So now submitting the previous RFC formally.
>> .34 / Stable candidate.
>
> Thanks Andi, will take a look at this next week.

I was wondering what the state of this patch is. I don't see it in
linux-2.6 or linux-next. or in
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git

Thanks,
John

2010-04-22 23:04:35

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] oprofile: remove double ring buffering

On Thu, 22 Apr 2010 10:33:56 -0400
John Villalovos <[email protected]> wrote:

> On Thu, Apr 1, 2010 at 3:02 PM, Robert Richter <[email protected]> wrote:
> > On 01.04.10 03:17:25, Andi Kleen wrote:
> >> Got confirmation now this patch fixes most of the dropped oprofile
> >> samples problem on a particular intensive test on a large system.
> >> So now submitting the previous RFC formally.
> >> .34 / Stable candidate.
> >
> > Thanks Andi, will take a look at this next week.
>
> I was wondering what the state of this patch is. I don't see it in
> linux-2.6 or linux-next. or in
> git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git
>

I queued it in my for-2.6.34-via-subsystem-maintainer pile. I'll start
sending those things out for everyone to ignore early next week I guess.

Subject: Re: [PATCH] oprofile: remove double ring buffering

On 22.04.10 16:04:11, Andrew Morton wrote:
> > I was wondering what the state of this patch is. I don't see it in
> > linux-2.6 or linux-next. or in
> > git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git
> >
>
> I queued it in my for-2.6.34-via-subsystem-maintainer pile. I'll start
> sending those things out for everyone to ignore early next week I guess.

I just make my tree ready for v2.6.35 and will put it in there.

The patch looks good, will run some tests.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]

Subject: Re: [PATCH] oprofile: remove double ring buffering

On 23.04.10 11:00:45, Robert Richter wrote:
> I just make my tree ready for v2.6.35 and will put it in there.
>
> The patch looks good, will run some tests.

The patch is now in the oprofile tree. Sorry for this late response.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]