2010-04-30 16:48:39

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the final tree (usb tree related)

---

Hi Greg,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_bits':
drivers/usb/otg/twl4030-usb.c:238: error: implicit declaration of function 'ULPI_SET'
drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_clear_bits':
drivers/usb/otg/twl4030-usb.c:244: error: implicit declaration of function 'ULPI_CLR'
drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_mode':
drivers/usb/otg/twl4030-usb.c:303: error: 'ULPI_IFC_CTRL' undeclared (first use in this function)
drivers/usb/otg/twl4030-usb.c:304: error: 'ULPI_IFC_CTRL_CARKITMODE' undeclared (first use in this function)
drivers/usb/otg/twl4030-usb.c:306: error: 'ULPI_FUNC_CTRL' undeclared (first use in this function)
drivers/usb/otg/twl4030-usb.c:307: error: 'ULPI_FUNC_CTRL_XCVRSEL_MASK' undeclared (first use in this function)
drivers/usb/otg/twl4030-usb.c:308: error: 'ULPI_FUNC_CTRL_OPMODE_MASK' undeclared (first use in this function)

Caused by commit 57983872ff14cba23d6404a40c89e52063c94854 ("usb: otg:
twl4030: use the global ULPI register definitions"). I have reverted
that commit for today.

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

---

Attachments:

(No filename) (1.25 kB)
(No filename) (198.00 B)
Download all attachments

2010-04-30 17:02:40

by Heikki Krogerus

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (usb tree related)

---

Hi,

On Fri, Apr 30, 2010 at 08:05:55AM +0200, ext Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_bits':
> drivers/usb/otg/twl4030-usb.c:238: error: implicit declaration of function 'ULPI_SET'
> drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_clear_bits':
> drivers/usb/otg/twl4030-usb.c:244: error: implicit declaration of function 'ULPI_CLR'
> drivers/usb/otg/twl4030-usb.c: In function 'twl4030_usb_set_mode':
> drivers/usb/otg/twl4030-usb.c:303: error: 'ULPI_IFC_CTRL' undeclared (first use in this function)
> drivers/usb/otg/twl4030-usb.c:304: error: 'ULPI_IFC_CTRL_CARKITMODE' undeclared (first use in this function)
> drivers/usb/otg/twl4030-usb.c:306: error: 'ULPI_FUNC_CTRL' undeclared (first use in this function)
> drivers/usb/otg/twl4030-usb.c:307: error: 'ULPI_FUNC_CTRL_XCVRSEL_MASK' undeclared (first use in this function)
> drivers/usb/otg/twl4030-usb.c:308: error: 'ULPI_FUNC_CTRL_OPMODE_MASK' undeclared (first use in this function)
>
> Caused by commit 57983872ff14cba23d6404a40c89e52063c94854 ("usb: otg:
> twl4030: use the global ULPI register definitions"). I have reverted
> that commit for today.

Already informed Greg that he needs the patch for the global ulpi
registers before this one.

--
heikki