2010-06-01 21:02:24

by Grant Grundler

[permalink] [raw]
Subject: Re: [PATCH 14/21] drivers/parisc/iosapic.c: Remove unnecessary kzalloc cast

On Mon, May 31, 2010 at 08:23:16PM -0700, Joe Perches wrote:
> Convert kzalloc to kcalloc
>
> Signed-off-by: Joe Perches <[email protected]>

Reviewed-by: Grant Grundler <[email protected]>

thanks,
grant

> ---
> drivers/parisc/iosapic.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
> index c768367..3e6f56c 100644
> --- a/drivers/parisc/iosapic.c
> +++ b/drivers/parisc/iosapic.c
> @@ -891,8 +891,8 @@ void *iosapic_register(unsigned long hpa)
> isi->isi_version = iosapic_rd_version(isi);
> isi->isi_num_vectors = IOSAPIC_IRDT_MAX_ENTRY(isi->isi_version) + 1;
>
> - vip = isi->isi_vector = (struct vector_info *)
> - kzalloc(sizeof(struct vector_info) * isi->isi_num_vectors, GFP_KERNEL);
> + vip = isi->isi_vector = kcalloc(isi->isi_num_vectors,
> + sizeof(struct vector_info), GFP_KERNEL);
> if (vip == NULL) {
> kfree(isi);
> return NULL;
> --
> 1.7.0.3.311.g6a6955
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html