2010-06-07 09:28:18

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Regression, post-rc1] Multiple issues after enabling SetVoltage on rs780m

Hi Alex,

Your commit 9349d5cc920c10845693f906ebd67f394f1d0d04
(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed
Acer Ferrari One to behave quite unreliably. The symptoms are:

- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system
reboot
- the system sometimes hangs hard during suspend to RAM

These problems are not reproducible with the commit above reverted.

Below is the information about the graphics adapter from lspci.

Rafael



01:05.0 VGA compatible controller: ATI Technologies Inc RS780M/RS780MN [Radeon HD 3200 Graphics] (prog-if 00 [VGA controller])
Subsystem: Acer Incorporated [ALI] Device 029e
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0, Cache Line Size: 32 bytes
Interrupt: pin A routed to IRQ 18
Region 0: Memory at a0000000 (32-bit, prefetchable) [size=256M]
Region 1: I/O ports at 9000 [size=256]
Region 2: Memory at 9fdf0000 (32-bit, non-prefetchable) [size=64K]
Region 5: Memory at 9fe00000 (32-bit, non-prefetchable) [size=1M]
Expansion ROM at <unassigned> [disabled]
Capabilities: [50] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [a0] MSI: Enable- Count=1/1 Maskable- 64bit+
Address: 0000000000000000 Data: 0000
Kernel driver in use: radeon


2010-06-07 10:15:35

by Dave Airlie

[permalink] [raw]
Subject: Re: [Regression, post-rc1] Multiple issues after enabling SetVoltage on rs780m

On Mon, Jun 7, 2010 at 7:29 PM, Rafael J. Wysocki <[email protected]> wrote:
> Hi Alex,
>
> Your commit 9349d5cc920c10845693f906ebd67f394f1d0d04
> (drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed
> Acer Ferrari One to behave quite unreliably. ?The symptoms are:
>
> - the system hangs hard (~ 50% of the time) when starting Xorg
> - the system hangs hard (~ 50% of the time) when stopping Xorg during system
> ?reboot
> - the system sometimes hangs hard during suspend to RAM
>
> These problems are not reproducible with the commit above reverted.
>
> Below is the information about the graphics adapter from lspci.

Reverting that commit on master fixes it?

that commit touches code paths in rv770 and evergreen that in no way
should affect that chipset which is an rs780, so takes the r600 paths.

are you sure its not 7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?

Dave.

2010-06-07 15:50:25

by Alex Deucher

[permalink] [raw]
Subject: Re: [Regression, post-rc1] Multiple issues after enabling SetVoltage on rs780m

On Mon, Jun 7, 2010 at 6:15 AM, Dave Airlie <[email protected]> wrote:
> On Mon, Jun 7, 2010 at 7:29 PM, Rafael J. Wysocki <[email protected]> wrote:
>> Hi Alex,
>>
>> Your commit 9349d5cc920c10845693f906ebd67f394f1d0d04
>> (drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed
>> Acer Ferrari One to behave quite unreliably. ?The symptoms are:
>>
>> - the system hangs hard (~ 50% of the time) when starting Xorg
>> - the system hangs hard (~ 50% of the time) when stopping Xorg during system
>> ?reboot
>> - the system sometimes hangs hard during suspend to RAM
>>
>> These problems are not reproducible with the commit above reverted.
>>
>> Below is the information about the graphics adapter from lspci.
>
> Reverting that commit on master fixes it?
>
> that commit touches code paths in rv770 and evergreen that in no way
> should affect that chipset which is an rs780, so takes the r600 paths.
>
> are you sure its not 7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?

It should be that commit if it is indeed the voltage adjust. That
said, I just took a closer look at the voltage adjust on newer IGPs
and unfortunately, it doesn't work the same as the discrete cards, so
for now we should disable it. The attached patch should do the trick.
There weren't any problems on my IGP chips, but they don't have a
SetVoltage table, so nothing is touching the hw.

Alex


Attachments:
0001-drm-radeon-kms-pm-Disable-voltage-adjust-on-RS780-RS.patch (1.59 kB)

2010-06-07 21:35:55

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Regression, post-rc1] Multiple issues after enabling SetVoltage on rs780m

On Monday 07 June 2010, Alex Deucher wrote:
> On Mon, Jun 7, 2010 at 6:15 AM, Dave Airlie <[email protected]> wrote:
> > On Mon, Jun 7, 2010 at 7:29 PM, Rafael J. Wysocki <[email protected]> wrote:
> >> Hi Alex,
> >>
> >> Your commit 9349d5cc920c10845693f906ebd67f394f1d0d04
> >> (drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed
> >> Acer Ferrari One to behave quite unreliably. The symptoms are:
> >>
> >> - the system hangs hard (~ 50% of the time) when starting Xorg
> >> - the system hangs hard (~ 50% of the time) when stopping Xorg during system
> >> reboot
> >> - the system sometimes hangs hard during suspend to RAM
> >>
> >> These problems are not reproducible with the commit above reverted.
> >>
> >> Below is the information about the graphics adapter from lspci.
> >
> > Reverting that commit on master fixes it?
> >
> > that commit touches code paths in rv770 and evergreen that in no way
> > should affect that chipset which is an rs780, so takes the r600 paths.
> >
> > are you sure its not 7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?
>
> It should be that commit if it is indeed the voltage adjust. That
> said, I just took a closer look at the voltage adjust on newer IGPs
> and unfortunately, it doesn't work the same as the discrete cards, so
> for now we should disable it. The attached patch should do the trick.
> There weren't any problems on my IGP chips, but they don't have a
> SetVoltage table, so nothing is touching the hw.

I'm not sure if the adapter is a discrete one.

Anyway, my testing was done before commit
386f40c86d6c8d5b717ef20620af1a750d0dacb4 and I'm unable to reproduce the
problems with current -git, so they might be a fallout of the bug fixed by that
commit.

Thanks,
Rafael

2010-06-07 22:42:21

by David Airlie

[permalink] [raw]
Subject: Re: [Regression, post-rc1] Multiple issues after enabling SetVoltage on rs780m

On Mon, 2010-06-07 at 23:37 +0200, Rafael J. Wysocki wrote:
> On Monday 07 June 2010, Alex Deucher wrote:
> > On Mon, Jun 7, 2010 at 6:15 AM, Dave Airlie <[email protected]> wrote:
> > > On Mon, Jun 7, 2010 at 7:29 PM, Rafael J. Wysocki <[email protected]> wrote:
> > >> Hi Alex,
> > >>
> > >> Your commit 9349d5cc920c10845693f906ebd67f394f1d0d04
> > >> (drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed
> > >> Acer Ferrari One to behave quite unreliably. The symptoms are:
> > >>
> > >> - the system hangs hard (~ 50% of the time) when starting Xorg
> > >> - the system hangs hard (~ 50% of the time) when stopping Xorg during system
> > >> reboot
> > >> - the system sometimes hangs hard during suspend to RAM
> > >>
> > >> These problems are not reproducible with the commit above reverted.
> > >>
> > >> Below is the information about the graphics adapter from lspci.
> > >
> > > Reverting that commit on master fixes it?
> > >
> > > that commit touches code paths in rv770 and evergreen that in no way
> > > should affect that chipset which is an rs780, so takes the r600 paths.
> > >
> > > are you sure its not 7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?
> >
> > It should be that commit if it is indeed the voltage adjust. That
> > said, I just took a closer look at the voltage adjust on newer IGPs
> > and unfortunately, it doesn't work the same as the discrete cards, so
> > for now we should disable it. The attached patch should do the trick.
> > There weren't any problems on my IGP chips, but they don't have a
> > SetVoltage table, so nothing is touching the hw.
>
> I'm not sure if the adapter is a discrete one.
>
> Anyway, my testing was done before commit
> 386f40c86d6c8d5b717ef20620af1a750d0dacb4 and I'm unable to reproduce the
> problems with current -git, so they might be a fallout of the bug fixed by that
> commit.
>

Yeah the sounded a lot more like the vt.c crapfest, since it was when
starting/stopping X.

Dave.