Divided a comment line into two separet lines in drivers/staging/rt3070/md4.h.
Signed-off-by: Matti Lammi <[email protected]>
---
drivers/staging/rt3070/md4.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rt3070/md4.h b/drivers/staging/rt3070/md4.h
index b3fb637..7ae9ebb 100644
--- a/drivers/staging/rt3070/md4.h
+++ b/drivers/staging/rt3070/md4.h
@@ -31,7 +31,8 @@
/* MD4 context. */
typedef struct _MD4_CTX_ {
unsigned long state[4]; /* state (ABCD) */
- unsigned long count[2]; /* number of bits, modulo 2^64 (lsb first) */
+ unsigned long count[2]; /* number of bits, modulo 2^64
+ (lsb first) */
u8 buffer[64]; /* input buffer */
} MD4_CTX;
--
1.6.0.4
Hi
On Thursday 10 June 2010, Matti Lammi wrote:
> Divided a comment line into two separet lines in drivers/staging/rt3070/md4.h.
Isn't drivers/staging/rt3070/ as a whole dead code by now? What about the
following removal patch instead (compile tested and no complaints from
rt30[79]0 users yet)?
As a side note, rt2800pci/ rt2800usb from drivers/net/wireless/rt2x00/ have
become fully functional for rt2770, rt2860, rt2870 (and I've gotten
very positive feedback for rt3070/ rt3090) with 2.6.35, so the staging
rt2860/ rt2870 drivers could be removed soon (now?). rt35xx support is
rt2x00-only anyways and HT rates aren't actually achievable by staging
(only by newer out-of-tree vendor drivers) or rt2x00 (work is under way)
yet.
From: Stefan Lippers-Hollmann <[email protected]>
Date: Wed, 24 Mar 2010 20:56:13 +0000
Subject: [PATCH] rt3070: remove dead code
While merging rt30[79]0 support into rt28[67]0, drivers/staging/rt3070/md4.h
has been forgotten, while it isn't referenced from the remaining drivers
anymore; remove it.
Signed-off-by: Stefan Lippers-Hollmann <[email protected]>
---
drivers/staging/rt3070/md4.h | 42 ------------------------------------------
1 files changed, 0 insertions(+), 42 deletions(-)
delete mode 100644 drivers/staging/rt3070/md4.h
diff --git a/drivers/staging/rt3070/md4.h b/drivers/staging/rt3070/md4.h
deleted file mode 100644
index b3fb637..0000000
--- a/drivers/staging/rt3070/md4.h
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- *************************************************************************
- * Ralink Tech Inc.
- * 5F., No.36, Taiyuan St., Jhubei City,
- * Hsinchu County 302,
- * Taiwan, R.O.C.
- *
- * (c) Copyright 2002-2007, Ralink Technology, Inc.
- *
- * This program is free software; you can redistribute it and/or modify *
- * it under the terms of the GNU General Public License as published by *
- * the Free Software Foundation; either version 2 of the License, or *
- * (at your option) any later version. *
- * *
- * This program is distributed in the hope that it will be useful, *
- * but WITHOUT ANY WARRANTY; without even the implied warranty of *
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
- * GNU General Public License for more details. *
- * *
- * You should have received a copy of the GNU General Public License *
- * along with this program; if not, write to the *
- * Free Software Foundation, Inc., *
- * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *
- * *
- *************************************************************************
- */
-
-#ifndef __MD4_H__
-#define __MD4_H__
-
-/* MD4 context. */
-typedef struct _MD4_CTX_ {
- unsigned long state[4]; /* state (ABCD) */
- unsigned long count[2]; /* number of bits, modulo 2^64 (lsb first) */
- u8 buffer[64]; /* input buffer */
-} MD4_CTX;
-
-void MD4Init(MD4_CTX *);
-void MD4Update(MD4_CTX *, u8 *, UINT);
-void MD4Final(u8 [16], MD4_CTX *);
-
-#endif /*__MD4_H__*/
--
1.7.1
Hi,
On Thursday 10 June 2010 03:21:42 pm Stefan Lippers-Hollmann wrote:
> Hi
>
> On Thursday 10 June 2010, Matti Lammi wrote:
> > Divided a comment line into two separet lines in drivers/staging/rt3070/md4.h.
>
> Isn't drivers/staging/rt3070/ as a whole dead code by now? What about the
> following removal patch instead (compile tested and no complaints from
> rt30[79]0 users yet)?
Looks fine to me, FWIW:
Acked-by: Bartlomiej Zolnierkiewicz <[email protected]>
> As a side note, rt2800pci/ rt2800usb from drivers/net/wireless/rt2x00/ have
> become fully functional for rt2770, rt2860, rt2870 (and I've gotten
> very positive feedback for rt3070/ rt3090) with 2.6.35, so the staging
> rt2860/ rt2870 drivers could be removed soon (now?). rt35xx support is
> rt2x00-only anyways and HT rates aren't actually achievable by staging
> (only by newer out-of-tree vendor drivers) or rt2x00 (work is under way)
> yet.
No idea here. The last time I tried rt2800 drivers was in 2.6.34-rc days
and my experiences were not exactly positive back then. Things may be
different nowadays or they may be not -- I don't have any time to spend on
this and staging drivers continue to work just fine for me at the moment.
> From: Stefan Lippers-Hollmann <[email protected]>
> Date: Wed, 24 Mar 2010 20:56:13 +0000
> Subject: [PATCH] rt3070: remove dead code
>
> While merging rt30[79]0 support into rt28[67]0, drivers/staging/rt3070/md4.h
> has been forgotten, while it isn't referenced from the remaining drivers
> anymore; remove it.
>
> Signed-off-by: Stefan Lippers-Hollmann <[email protected]>
> ---
> drivers/staging/rt3070/md4.h | 42 ------------------------------------------
> 1 files changed, 0 insertions(+), 42 deletions(-)
> delete mode 100644 drivers/staging/rt3070/md4.h
>
> diff --git a/drivers/staging/rt3070/md4.h b/drivers/staging/rt3070/md4.h
> deleted file mode 100644
> index b3fb637..0000000
> --- a/drivers/staging/rt3070/md4.h
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -/*
> - *************************************************************************
> - * Ralink Tech Inc.
> - * 5F., No.36, Taiyuan St., Jhubei City,
> - * Hsinchu County 302,
> - * Taiwan, R.O.C.
> - *
> - * (c) Copyright 2002-2007, Ralink Technology, Inc.
> - *
> - * This program is free software; you can redistribute it and/or modify *
> - * it under the terms of the GNU General Public License as published by *
> - * the Free Software Foundation; either version 2 of the License, or *
> - * (at your option) any later version. *
> - * *
> - * This program is distributed in the hope that it will be useful, *
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of *
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
> - * GNU General Public License for more details. *
> - * *
> - * You should have received a copy of the GNU General Public License *
> - * along with this program; if not, write to the *
> - * Free Software Foundation, Inc., *
> - * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *
> - * *
> - *************************************************************************
> - */
> -
> -#ifndef __MD4_H__
> -#define __MD4_H__
> -
> -/* MD4 context. */
> -typedef struct _MD4_CTX_ {
> - unsigned long state[4]; /* state (ABCD) */
> - unsigned long count[2]; /* number of bits, modulo 2^64 (lsb first) */
> - u8 buffer[64]; /* input buffer */
> -} MD4_CTX;
> -
> -void MD4Init(MD4_CTX *);
> -void MD4Update(MD4_CTX *, u8 *, UINT);
> -void MD4Final(u8 [16], MD4_CTX *);
> -
> -#endif /*__MD4_H__*/
--
Bartlomiej Zolnierkiewicz