2010-06-16 19:07:58

by Stephane Eranian

Subject: [PATCH] perf: avoid synthesizing mmap() for all processes in per-thread mode perf record

A bug was introduced by commit c45c6ea2e5c57960dc67e00294c2b78e9540c007.

Perf record was scanning /proc/PID to create synthetic PERF_RECOR_MMAP
entries even though it was running in per-thread mode. There was a bogus
check to select what mmaps to synthesize. We only need all processes in
system-wide mode.

Signed-off-by: Stephane Eranian <[email protected]>

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 39c7247..5efc3fc 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -714,7 +714,7 @@ static int __cmd_record(int argc, const char **argv)
if (perf_guest)
perf_session__process_machines(session, event__synthesize_guest_os);

- if (!system_wide && cpu_list)
+ if (!system_wide)
event__synthesize_thread(target_tid, process_synthesized_event,
session);
else

2010-06-16 20:51:23

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf: avoid synthesizing mmap() for all processes in per-thread mode perf record

Em Wed, Jun 16, 2010 at 08:59:01PM +0200, Stephane Eranian escreveu:
> A bug was introduced by commit c45c6ea2e5c57960dc67e00294c2b78e9540c007.
>
> Perf record was scanning /proc/PID to create synthetic PERF_RECOR_MMAP
> entries even though it was running in per-thread mode. There was a bogus
> check to select what mmaps to synthesize. We only need all processes in
> system-wide mode.
>
> Signed-off-by: Stephane Eranian <[email protected]>

Thanks, appling to perf/urgent

- Arnaldo