2010-06-22 09:09:18

by Wan ZongShun

Subject: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900

Use rtc_valid_tm to check returning tm for max6900,
it can avoid returning wrong tm value.
---
drivers/rtc/rtc-max6900.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
index a4f6665..486142c 100644
--- a/drivers/rtc/rtc-max6900.c
+++ b/drivers/rtc/rtc-max6900.c
@@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);

- return 0;
+ return rtc_valid_tm(tm);
}

static int max6900_i2c_clear_write_protect(struct i2c_client *client)
--
1.6.3.3

2010-06-22 09:42:03

by Wan ZongShun

Subject: Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900

Signed-off-by: Wan ZongShun <[email protected]>

> Use rtc_valid_tm to check returning tm for max6900,
> it can avoid returning wrong tm value.
> ---
>  drivers/rtc/rtc-max6900.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
> index a4f6665..486142c 100644
> --- a/drivers/rtc/rtc-max6900.c
> +++ b/drivers/rtc/rtc-max6900.c
> @@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
>                      bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
>        tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
>
> -       return 0;
> +       return rtc_valid_tm(tm);
>  }
>
>  static int max6900_i2c_clear_write_protect(struct i2c_client *client)
> --
> 1.6.3.3
>



--
*linux-arm-kernel mailing list
mail addr:[email protected]
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:[email protected]
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
[email protected]

2010-06-22 13:35:45

by Dale Farnsworth

Subject: Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900

On Tue, Jun 22, 2010 at 05:09:03PM +0800, Wan ZongShun wrote:
> Use rtc_valid_tm to check returning tm for max6900,
> it can avoid returning wrong tm value.
> ---
> drivers/rtc/rtc-max6900.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
> index a4f6665..486142c 100644
> --- a/drivers/rtc/rtc-max6900.c
> +++ b/drivers/rtc/rtc-max6900.c
> @@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
> bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
> tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
>
> - return 0;
> + return rtc_valid_tm(tm);
> }
>
> static int max6900_i2c_clear_write_protect(struct i2c_client *client)

Ack.

Thanks,
-Dale