2010-07-02 11:54:51

by Michal Marek

Subject: [PATCH] scripts/dtc: Fix a resource leak

From: Martin Ettl <[email protected]>

during a check of the current git head of the linux kernel with the
static code analysis tool cppcheck
(http://sourceforge.net/apps/mediawiki/cppcheck/index.php?title=Main_Page)
the tool discovered a resource leak in linux-2.6/scripts/dtc/fstree.c.

Please refer the attached patch, that fixes the issue.

Fixes https://bugzilla.kernel.org/show_bug.cgi?id=15363
Signed-off-by: Martin Ettl <[email protected]>
Cc: David Gibson <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
---
scripts/dtc/fstree.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/scripts/dtc/fstree.c b/scripts/dtc/fstree.c
index 766b269..8fe1bdf 100644
--- a/scripts/dtc/fstree.c
+++ b/scripts/dtc/fstree.c
@@ -77,6 +77,7 @@ static struct node *read_fstree(const char *dirname)
free(tmpnam);
}

+ closedir(d);
return tree;
}

--
1.7.1

2010-07-03 02:32:08

by David Gibson

Subject: Re: [PATCH] scripts/dtc: Fix a resource leak

On Fri, Jul 02, 2010 at 01:52:14PM +0200, Michal Marek wrote:
> From: Martin Ettl <[email protected]>
>
> during a check of the current git head of the linux kernel with the
> static code analysis tool cppcheck
> (http://sourceforge.net/apps/mediawiki/cppcheck/index.php?title=Main_Page)
> the tool discovered a resource leak in linux-2.6/scripts/dtc/fstree.c.
>
> Please refer the attached patch, that fixes the issue.

I'll submit a patch for this to upstream dtc.

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson