2010-07-05 08:01:12

by Kulikov Vasiliy

Subject: [PATCH] kernel/watchdog: Initialize 'result'

Variable on the stack is not initialized to zero, do it explicitly.

This patch silences a compiler warning:
kernel/watchdog.c:463: warning: ‘result’ may be used uninitialized in this function

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
kernel/watchdog.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 91b0b26..613bc1f 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -460,7 +460,7 @@ static void watchdog_disable(int cpu)
static void watchdog_enable_all_cpus(void)
{
int cpu;
- int result;
+ int result = 0;

for_each_online_cpu(cpu)
result += watchdog_enable(cpu);
--
1.7.0.4

2010-07-06 13:23:37

by Don Zickus

Subject: Re: [PATCH] kernel/watchdog: Initialize 'result'

On Mon, Jul 05, 2010 at 12:00:54PM +0400, Kulikov Vasiliy wrote:
> Variable on the stack is not initialized to zero, do it explicitly.
>
> This patch silences a compiler warning:
> kernel/watchdog.c:463: warning: ‘result’ may be used uninitialized in this function

Hmm, I thought I fixed that. oh well.

ACK.

>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> kernel/watchdog.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 91b0b26..613bc1f 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -460,7 +460,7 @@ static void watchdog_disable(int cpu)
> static void watchdog_enable_all_cpus(void)
> {
> int cpu;
> - int result;
> + int result = 0;
>
> for_each_online_cpu(cpu)
> result += watchdog_enable(cpu);
> --
> 1.7.0.4
>

2010-07-07 08:04:23

by Kulikov Vasiliy

Subject: [tip:perf/nmi] kernel/watchdog: Initialize 'result'

Commit-ID: eb703f98191a505f78d0066712ad67d5dedc4c90
Gitweb: http://git.kernel.org/tip/eb703f98191a505f78d0066712ad67d5dedc4c90
Author: Kulikov Vasiliy <[email protected]>
AuthorDate: Mon, 5 Jul 2010 12:00:54 +0400
Committer: Ingo Molnar <[email protected]>
CommitDate: Wed, 7 Jul 2010 08:46:42 +0200

kernel/watchdog: Initialize 'result'

Variable on the stack is not initialized to zero, do it
explicitly.

This bug was found by a compiler warning:

kernel/watchdog.c:463: warning: 'result' may be used uninitialized in this function

Signed-off-by: Kulikov Vasiliy <[email protected]>
Acked-by: Don Zickus <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Steven Rostedt <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/watchdog.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 91b0b26..613bc1f 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -460,7 +460,7 @@ static void watchdog_disable(int cpu)
static void watchdog_enable_all_cpus(void)
{
int cpu;
- int result;
+ int result = 0;

for_each_online_cpu(cpu)
result += watchdog_enable(cpu);