2010-07-02 12:41:14

by Anton Vorontsov

Subject: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency

Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
driver became non-selectable.

This patch fixes the issue by switching to PPC_85xx symbol.

Signed-off-by: Anton Vorontsov <[email protected]>
---
drivers/edac/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index aedef79..0d2f9db 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -209,7 +209,7 @@ config EDAC_I5100

config EDAC_MPC85XX
tristate "Freescale MPC83xx / MPC85xx"
- depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
+ depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
help
Support for error detection and correction on the Freescale
MPC8349, MPC8560, MPC8540, MPC8548
--
1.7.0.5

2010-07-07 21:45:44

by Andrew Morton

Subject: Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency

On Fri, 2 Jul 2010 16:41:11 +0400
Anton Vorontsov <[email protected]> wrote:

> Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
> Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
> driver became non-selectable.

hm. 5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline
six months ago. How come nobody noticed?

> This patch fixes the issue by switching to PPC_85xx symbol.
>
> Signed-off-by: Anton Vorontsov <[email protected]>
> ---
> drivers/edac/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index aedef79..0d2f9db 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -209,7 +209,7 @@ config EDAC_I5100
>
> config EDAC_MPC85XX
> tristate "Freescale MPC83xx / MPC85xx"
> - depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
> + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
> help
> Support for error detection and correction on the Freescale
> MPC8349, MPC8560, MPC8540, MPC8548

I suppose we shold scoot this into 2.6.35 and mark it for -stable
backporting. All very odd.

2010-07-08 04:56:33

by Anton Vorontsov

Subject: Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency

On Wed, Jul 07, 2010 at 02:45:02PM -0700, Andrew Morton wrote:
> On Fri, 2 Jul 2010 16:41:11 +0400
> Anton Vorontsov <[email protected]> wrote:
>
> > Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
> > Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
> > driver became non-selectable.
>
> hm. 5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline
> six months ago. How come nobody noticed?

Dunno. Well, it's hard to notice these sorts of things until
somebody actually needs this driver on MPC85xx platform. :-)

> > This patch fixes the issue by switching to PPC_85xx symbol.
> >
> > Signed-off-by: Anton Vorontsov <[email protected]>
> > ---
[...]
> > - depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
> > + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
> > help
> > Support for error detection and correction on the Freescale
> > MPC8349, MPC8560, MPC8540, MPC8548
>
> I suppose we shold scoot this into 2.6.35 and mark it for -stable
> backporting. All very odd.

Yeah, -stable 2.6.{33,34} sounds good.

Thanks.

2010-07-11 16:21:14

by Kumar Gala

Subject: Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency

On Jul 7, 2010, at 11:56 PM, Anton Vorontsov wrote:

> On Wed, Jul 07, 2010 at 02:45:02PM -0700, Andrew Morton wrote:
>> On Fri, 2 Jul 2010 16:41:11 +0400
>> Anton Vorontsov <[email protected]> wrote:
>>
>>> Since commit 5753c082f66eca5be81f6bda85c1718c5eea6ada ("powerpc/85xx:
>>> Kconfig cleanup"), there is no MPC85xx Kconfig symbol anymore, so the
>>> driver became non-selectable.
>>
>> hm. 5753c082f66eca5be81f6bda85c1718c5eea6ada got merged into mainline
>> six months ago. How come nobody noticed?
>
> Dunno. Well, it's hard to notice these sorts of things until
> somebody actually needs this driver on MPC85xx platform. :-)
>
>>> This patch fixes the issue by switching to PPC_85xx symbol.
>>>
>>> Signed-off-by: Anton Vorontsov <[email protected]>
>>> ---
> [...]
>>> - depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || MPC85xx)
>>> + depends on EDAC_MM_EDAC && FSL_SOC && (PPC_83xx || PPC_85xx)
>>> help
>>> Support for error detection and correction on the Freescale
>>> MPC8349, MPC8560, MPC8540, MPC8548
>>
>> I suppose we shold scoot this into 2.6.35 and mark it for -stable
>> backporting. All very odd.
>
> Yeah, -stable 2.6.{33,34} sounds good.
>
> Thanks.

we should add this to mpc85xx_defconfig so we build by default.

- k