2010-07-08 01:52:56

by Axel Lin

[permalink] [raw]
Subject: [PATCH] classmate-laptop: make needlessly global symbols static

cmpc_accel_sensitivity_attr is needlessly defined global.
This patch makes the symbol static.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/platform/x86/classmate-laptop.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index 3bf399f..6c63303 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -208,7 +208,7 @@ static ssize_t cmpc_accel_sensitivity_store(struct device *dev,
return strnlen(buf, count);
}

-struct device_attribute cmpc_accel_sensitivity_attr = {
+static struct device_attribute cmpc_accel_sensitivity_attr = {
.attr = { .name = "sensitivity", .mode = 0660 },
.show = cmpc_accel_sensitivity_show,
.store = cmpc_accel_sensitivity_store
--
1.5.4.3



Subject: Re: [PATCH] classmate-laptop: make needlessly global symbols static

On Thu, Jul 08, 2010 at 09:47:50AM +0800, Axel Lin wrote:
> cmpc_accel_sensitivity_attr is needlessly defined global.
> This patch makes the symbol static.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/platform/x86/classmate-laptop.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index 3bf399f..6c63303 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -208,7 +208,7 @@ static ssize_t cmpc_accel_sensitivity_store(struct device *dev,
> return strnlen(buf, count);
> }
>
> -struct device_attribute cmpc_accel_sensitivity_attr = {
> +static struct device_attribute cmpc_accel_sensitivity_attr = {
> .attr = { .name = "sensitivity", .mode = 0660 },
> .show = cmpc_accel_sensitivity_show,
> .store = cmpc_accel_sensitivity_store
> --
> 1.5.4.3
>
>
>

Acked-by: Thadeu Lima de Souza Cascardo <[email protected]

Attachments:
(No filename) (1.00 kB)
 signature.asc (836.00 B)
Digital signature Download all attachments