2010-07-09 19:15:47

by Christoph Lameter

[permalink] [raw]
Subject: [S+Q2 11/19] slub: Remove static kmem_cache_cpu array for boot

The percpu allocator can now handle allocations in early boot.
So drop the static kmem_cache_cpu array.

Cc: Tejun Heo <[email protected]>
Signed-off-by: Christoph Lameter <[email protected]>

---
mm/slub.c | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c 2010-07-06 15:15:42.000000000 -0500
+++ linux-2.6/mm/slub.c 2010-07-06 15:15:52.000000000 -0500
@@ -2068,23 +2068,14 @@ init_kmem_cache_node(struct kmem_cache_n
#endif
}

-static DEFINE_PER_CPU(struct kmem_cache_cpu, kmalloc_percpu[KMALLOC_CACHES]);
-
static inline int alloc_kmem_cache_cpus(struct kmem_cache *s)
{
- if (s < kmalloc_caches + KMALLOC_CACHES && s >= kmalloc_caches)
- /*
- * Boot time creation of the kmalloc array. Use static per cpu data
- * since the per cpu allocator is not available yet.
- */
- s->cpu_slab = kmalloc_percpu + (s - kmalloc_caches);
- else
- s->cpu_slab = alloc_percpu(struct kmem_cache_cpu);
+ BUILD_BUG_ON(PERCPU_DYNAMIC_EARLY_SIZE <
+ SLUB_PAGE_SHIFT * sizeof(struct kmem_cache));

- if (!s->cpu_slab)
- return 0;
+ s->cpu_slab = alloc_percpu(struct kmem_cache_cpu);

- return 1;
+ return s->cpu_slab != NULL;
}

#ifdef CONFIG_NUMA