2010-07-14 10:57:34

by Axel Lin

Subject: [PATCH] wm8727: add a missing return in wm8727_platform_probe

otherwise the error path will always be executed.

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/codecs/wm8727.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/soc/codecs/wm8727.c b/sound/soc/codecs/wm8727.c
index 1072621..9d1df26 100644
--- a/sound/soc/codecs/wm8727.c
+++ b/sound/soc/codecs/wm8727.c
@@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev)
goto err_codec;
}

+ return 0;
+
err_codec:
snd_soc_unregister_codec(codec);
err:
--
1.7.0.4

2010-07-14 15:07:43

by Liam Girdwood

Subject: Re: [PATCH] wm8727: add a missing return in wm8727_platform_probe

On Wed, 2010-07-14 at 18:57 +0800, Axel Lin wrote:
> otherwise the error path will always be executed.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> sound/soc/codecs/wm8727.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8727.c b/sound/soc/codecs/wm8727.c
> index 1072621..9d1df26 100644
> --- a/sound/soc/codecs/wm8727.c
> +++ b/sound/soc/codecs/wm8727.c
> @@ -127,6 +127,8 @@ static __devinit int wm8727_platform_probe(struct platform_device *pdev)
> goto err_codec;
> }
>
> + return 0;
> +
> err_codec:
> snd_soc_unregister_codec(codec);
> err:

Both

Acked-by: Liam Girdwood <[email protected]>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-07-14 19:26:17

by Mark Brown

Subject: Re: [PATCH] wm8727: add a missing return in wm8727_platform_probe

On Wed, Jul 14, 2010 at 03:59:57PM +0100, Liam Girdwood wrote:
> On Wed, 2010-07-14 at 18:57 +0800, Axel Lin wrote:
> > otherwise the error path will always be executed.

> Both

> Acked-by: Liam Girdwood <[email protected]>

...and applied, thanks.