2010-07-14 18:05:58

by Kulikov Vasiliy

Subject: [PATCH 09/11] staging: msm: formatting of pointers in printk()

Use %p instead of %08x in printk().

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index 8d16380..8b49cb1 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)

for (i = 0; i < len; i++) {
if (i % 16 == 0)
- printk("\n0x%08x:", (unsigned int)cptr);
+ printk("\n%p:", cptr);

printk(" %02x", *(cptr++));
}
--
1.7.0.4

2010-07-14 18:21:50

by Joe Perches

Subject: Re: [PATCH 09/11] staging: msm: formatting of pointers in printk()

On Wed, 2010-07-14 at 22:05 +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index 8d16380..8b49cb1 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
>
> for (i = 0; i < len; i++) {
> if (i % 16 == 0)
> - printk("\n0x%08x:", (unsigned int)cptr);
> + printk("\n%p:", cptr);
>
> printk(" %02x", *(cptr++));
> }

I was originally going to suggest a conversion
to print_hex_dump, but this function isn't used
and it and daqp_dump might as well be removed.

2010-07-14 20:54:56

by Greg KH

Subject: Re: [PATCH 09/11] staging: msm: formatting of pointers in printk()

On Wed, Jul 14, 2010 at 10:05:17PM +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-

Why does your Subject: say "msm"?

greg k-h

2010-07-14 22:32:16

by David Brown

Subject: Re: [PATCH 09/11] staging: msm: formatting of pointers in printk()

On Wednesday 14 July 2010 11:05:17 Kulikov Vasiliy wrote:

> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-

Did you mean to have an 'msm:' in the subject? This driver isn't part
of the msm subsystem?

Thanks,
David Brown

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.