2010-07-15 18:44:37

by Kulikov Vasiliy

[permalink] [raw]
Subject: [PATCH 2/8] touchscreen: fix sign bug

platform_get_irq_byname() can return negative results, it is not seen to
unsigned ts_irq. Make it signed.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/input/touchscreen/stmpe-ts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 77f4374..656148e 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
struct input_dev *idev;
struct stmpe_ts_platform_data *ts_pdata = NULL;
int ret = 0;
- unsigned int ts_irq;
+ int ts_irq;

ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
if (ts_irq < 0)
--
1.7.0.4


2010-07-15 20:49:33

by Luotao Fu

[permalink] [raw]
Subject: Re: [PATCH 2/8] touchscreen: fix sign bug

On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned ts_irq. Make it signed.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>

Acked-By: Luotao Fu <[email protected]>

> ---
> drivers/input/touchscreen/stmpe-ts.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 77f4374..656148e 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
> struct input_dev *idev;
> struct stmpe_ts_platform_data *ts_pdata = NULL;
> int ret = 0;
> - unsigned int ts_irq;
> + int ts_irq;
>
> ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
> if (ts_irq < 0)
> --
> 1.7.0.4
>

Stupid bug. Thanks for catching this.

cheers
Luotao Fu

--
Pengutronix e.K. | Dipl.-Ing. Luotao Fu |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachments:
(No filename) (1.26 kB)
 signature.asc (197.00 B)
Digital signature Download all attachments

2010-07-16 07:18:54

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH 2/8] touchscreen: fix sign bug

On Thu, Jul 15, 2010 at 10:49:27PM +0200, Luotao Fu wrote:
> On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> > platform_get_irq_byname() can return negative results, it is not seen to
> > unsigned ts_irq. Make it signed.
> >
> > Signed-off-by: Kulikov Vasiliy <[email protected]>
>
> Acked-By: Luotao Fu <[email protected]>
>

OK, the driver is still in Samuel's tree so he gets to pick the patch...

Thanks.

--
Dmitry

2010-07-25 21:32:43

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH 2/8] touchscreen: fix sign bug

Hi Vasiliy,

On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote:
> platform_get_irq_byname() can return negative results, it is not seen to
> unsigned ts_irq. Make it signed.
Patch applied to my mfd tree, thanks.

Cheers,
Samuel.


> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> drivers/input/touchscreen/stmpe-ts.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 77f4374..656148e 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev)
> struct input_dev *idev;
> struct stmpe_ts_platform_data *ts_pdata = NULL;
> int ret = 0;
> - unsigned int ts_irq;
> + int ts_irq;
>
> ts_irq = platform_get_irq_byname(pdev, "FIFO_TH");
> if (ts_irq < 0)
> --
> 1.7.0.4
>

--
Intel Open Source Technology Centre
http://oss.intel.com/