2010-07-12 01:14:59

by Axel Lin

Subject: [PATCH] eeepc-laptop: fix hotplug_disabled module_param permissions

The hotplug_disabled module parameter is determinated at the module load time.
Change the value after the module is loaded does not make sense and has
no effect at all, thus set the permissions to 0444 instead of 0644.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/platform/x86/eeepc-laptop.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index 0306174..6b8e062 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -53,7 +53,7 @@ MODULE_LICENSE("GPL");

static bool hotplug_disabled;

-module_param(hotplug_disabled, bool, 0644);
+module_param(hotplug_disabled, bool, 0444);
MODULE_PARM_DESC(hotplug_disabled,
"Disable hotplug for wireless device. "
"If your laptop need that, please report to "
--
1.5.4.3

2010-07-22 15:11:14

by Matthew Garrett

Subject: Re: [PATCH] eeepc-laptop: fix hotplug_disabled module_param permissions

I think I've got all of your patches merged now, but let me know if I've
missed any. They should be in my linux-next branch.

--
Matthew Garrett | [email protected]

2010-07-23 00:46:10

by Axel Lin

Subject: Re: [PATCH] eeepc-laptop: fix hotplug_disabled module_param permissions

2010/7/22 Matthew Garrett <[email protected]>:
> I think I've got all of your patches merged now, but let me know if I've
> missed any. They should be in my linux-next branch.

hi Matthew,
Thanks for merging the patches.

Below 3 patches are missing:
[PATCH] asus-laptop: fix asus_input_init error path
http://lkml.org/lkml/2010/7/5/21
[PATCH] dell-laptop: make dell_laptop_i8042_filter() static
http://lkml.org/lkml/2010/7/5/69
[PATCH] msi-wmi: make needlessly global symbols static
http://lkml.org/lkml/2010/7/8/66

Regards,
Axel