LinuxLists.cc - linux-next: build failure after merge of the ieee1394 tree

2010-07-27 01:48:48

Subject: linux-next: build failure after merge of the ieee1394 tree

Hi all,

After merging the ieee1394 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/firewire/nosy.c: In function 'packet_buffer_get':
drivers/firewire/nosy.c:154: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
drivers/firewire/nosy.c:154: error: implicit declaration of function 'signal_pending'
drivers/firewire/nosy.c:154: error: implicit declaration of function 'schedule'
drivers/firewire/nosy.c: In function 'packet_buffer_put':
drivers/firewire/nosy.c:221: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
drivers/firewire/nosy.c: In function 'remove_card':
drivers/firewire/nosy.c:514: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)

Forgot to include something?

I have used the ieee1394 tree from next-20100726 for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

Attachments:

(No filename) (927.00 B)
(No filename) (490.00 B)
Download all attachments

2010-07-27 08:08:06

by Stefan Richter

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the ieee1394 tree

Stephen Rothwell wrote:
> After merging the ieee1394 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/firewire/nosy.c: In function 'packet_buffer_get':
> drivers/firewire/nosy.c:154: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> drivers/firewire/nosy.c:154: error: implicit declaration of function 'signal_pending'
> drivers/firewire/nosy.c:154: error: implicit declaration of function 'schedule'
> drivers/firewire/nosy.c: In function 'packet_buffer_put':
> drivers/firewire/nosy.c:221: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> drivers/firewire/nosy.c: In function 'remove_card':
> drivers/firewire/nosy.c:514: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
>
> Forgot to include something?
>
> I have used the ieee1394 tree from next-20100726 for today.

Oh right. Every user of <linux/wait.h> must also include
<linux/sched.h>, unfortunately. I saw the same problem months ago with
another driver, I wonder why I did not catch it this time.

I will fix it later today. This code is in a topic branch for a new
driver; I will rewrite that branch to stay fully bisectable.
--
Stefan Richter
-=====-==-=- -=== ==-==
http://arcgraph.de/sr/