2010-07-27 13:29:48

by Ondrej Zary

Subject: [PATCH] [resend] cyber2000fb: add mode_option parameter

Add mode_option parameter to specify the default video mode.

Signed-off-by: Ondrej Zary <[email protected]>

--- linux-2.6.35-rc3-/drivers/video/cyber2000fb.c 2010-07-25 21:28:33.000000000 +0200
+++ linux-2.6.35-rc3/drivers/video/cyber2000fb.c 2010-07-25 20:36:49.000000000 +0200
@@ -94,6 +94,10 @@ static char *default_font = "Acorn8x8";
module_param(default_font, charp, 0);
MODULE_PARM_DESC(default_font, "Default font name");

+static char *mode_option __devinitdata = "640x480-8@60";
+module_param(mode_option, charp, 0444);
+MODULE_PARM_DESC(mode_option, "Default video mode ('640x480-8@60', etc)");
+
/*
* Our access methods.
*/
@@ -1368,7 +1372,7 @@ static int __devinit cyberpro_common_pro
cfb->fb.screen_base = cfb->region;

err = -EINVAL;
- if (!fb_find_mode(&cfb->fb.var, &cfb->fb, NULL, NULL, 0,
+ if (!fb_find_mode(&cfb->fb.var, &cfb->fb, mode_option, NULL, 0,
&cyber2000fb_default_mode, 8)) {
printk(KERN_ERR "%s: no valid mode found\n", cfb->fb.fix.id);
goto failed;

--
Ondrej Zary

2010-07-27 16:22:09

by Russell King - ARM Linux

Subject: Re: [PATCH] [resend] cyber2000fb: add mode_option parameter

On Tue, Jul 27, 2010 at 03:29:41PM +0200, Ondrej Zary wrote:
> Add mode_option parameter to specify the default video mode.

This patch is fine...