2010-07-28 18:43:20

by Peter Huewe

Subject: [PATCH] arm/mach-ixp2000: Add missing comma - fix build failure

From: Peter Huewe <[email protected]>

This trivial patch fixes a build failure [1] by adding a missing comma.

Signed-off-by: Peter Huewe <[email protected]>
---
KernelVersion: linux-next-20100728

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/2980895/

BF introduced by 3cad685d - ARM: 6253/1: Add 'code' parameter for
hook_fault_code()

arch/arm/mach-ixp2000/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-ixp2000/pci.c b/arch/arm/mach-ixp2000/pci.c
index 853fd90..f797c5f 100644
--- a/arch/arm/mach-ixp2000/pci.c
+++ b/arch/arm/mach-ixp2000/pci.c
@@ -209,7 +209,7 @@ ixp2000_pci_preinit(void)
"the needed workaround has not been configured in");
#endif

- hook_fault_code(16+6, ixp2000_pci_abort_handler, SIGBUS, 0
+ hook_fault_code(16+6, ixp2000_pci_abort_handler, SIGBUS, 0,
"PCI config cycle to non-existent device");
}

--
1.7.1

2010-07-28 19:15:33

by Kirill A. Shutemov

Subject: Re: [PATCH] arm/mach-ixp2000: Add missing comma - fix build failure

On Wed, Jul 28, 2010 at 08:43:13PM +0200, Peter Huewe wrote:
> From: Peter Huewe <[email protected]>
>
> This trivial patch fixes a build failure [1] by adding a missing comma.

It has been fixed by updated patch:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6269/1

Thank you.

>
> Signed-off-by: Peter Huewe <[email protected]>
> ---
> KernelVersion: linux-next-20100728
>
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/2980895/
>
> BF introduced by 3cad685d - ARM: 6253/1: Add 'code' parameter for
> hook_fault_code()
>
> arch/arm/mach-ixp2000/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-ixp2000/pci.c b/arch/arm/mach-ixp2000/pci.c
> index 853fd90..f797c5f 100644
> --- a/arch/arm/mach-ixp2000/pci.c
> +++ b/arch/arm/mach-ixp2000/pci.c
> @@ -209,7 +209,7 @@ ixp2000_pci_preinit(void)
> "the needed workaround has not been configured in");
> #endif
>
> - hook_fault_code(16+6, ixp2000_pci_abort_handler, SIGBUS, 0
> + hook_fault_code(16+6, ixp2000_pci_abort_handler, SIGBUS, 0,
> "PCI config cycle to non-existent device");
> }
>
> --
> 1.7.1
>

--
Kirill A. Shutemov

2010-07-28 19:50:33

by Russell King - ARM Linux

Subject: Re: [PATCH] arm/mach-ixp2000: Add missing comma - fix build failure

On Wed, Jul 28, 2010 at 10:15:31PM +0300, Kirill A. Shutemov wrote:
> On Wed, Jul 28, 2010 at 08:43:13PM +0200, Peter Huewe wrote:
> > From: Peter Huewe <[email protected]>
> >
> > This trivial patch fixes a build failure [1] by adding a missing comma.
>
> It has been fixed by updated patch:
>
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6269/1

And committed. I want to give the MMCI changes I've committed yesterday
a run before I push the tree out though.