2010-07-28 18:30:07

by Peter Huewe

Subject: [PATCH] video/w100fb: ignore void return value / fix build failure

From: Peter Huewe <[email protected]>

This patch fixes a build failure [1] (error: void value not ignored as
it ought to be) by removing an assignment of a void return value.
The functionality of the code is not changed.

Signed-off-by: Peter Huewe <[email protected]>
---
KernelVersion: linux-next-20100728
References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/2980912/

drivers/video/w100fb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
index e66b8b1..d8b12c3 100644
--- a/drivers/video/w100fb.c
+++ b/drivers/video/w100fb.c
@@ -858,9 +858,9 @@ unsigned long w100fb_gpio_read(int port)
void w100fb_gpio_write(int port, unsigned long value)
{
if (port==W100_GPIO_PORT_A)
- value = writel(value, remapped_regs + mmGPIO_DATA);
+ writel(value, remapped_regs + mmGPIO_DATA);
else
- value = writel(value, remapped_regs + mmGPIO_DATA2);
+ writel(value, remapped_regs + mmGPIO_DATA2);
}
EXPORT_SYMBOL(w100fb_gpio_read);
EXPORT_SYMBOL(w100fb_gpio_write);
--
1.7.1

2010-07-28 19:09:08

by tip-bot for Henrik Kretzschmar

Subject: Re: [PATCH] video/w100fb: ignore void return value / fix build failure

Am 28.07.2010 20:29, schrieb Peter H?we:
> From: Peter Huewe <[email protected]>
>
> This patch fixes a build failure [1] (error: void value not ignored as
> it ought to be) by removing an assignment of a void return value.
> The functionality of the code is not changed.
>
> Signed-off-by: Peter Huewe <[email protected]>
Ached-by: Henrik Kretzschmar <[email protected]>
> ---
> KernelVersion: linux-next-20100728
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/2980912/
>
> drivers/video/w100fb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
> index e66b8b1..d8b12c3 100644
> --- a/drivers/video/w100fb.c
> +++ b/drivers/video/w100fb.c
> @@ -858,9 +858,9 @@ unsigned long w100fb_gpio_read(int port)
> void w100fb_gpio_write(int port, unsigned long value)
> {
> if (port==W100_GPIO_PORT_A)
> - value = writel(value, remapped_regs + mmGPIO_DATA);
> + writel(value, remapped_regs + mmGPIO_DATA);
> else
> - value = writel(value, remapped_regs + mmGPIO_DATA2);
> + writel(value, remapped_regs + mmGPIO_DATA2);
> }
> EXPORT_SYMBOL(w100fb_gpio_read);
> EXPORT_SYMBOL(w100fb_gpio_write);