2010-07-03 16:04:45

by Kulikov Vasiliy

Subject: [PATCH 17/19] drivers/pci: use for_each_pci_dev()

Use for_each_pci_dev() to simplify the code.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/pci/setup-irq.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
index aa795fd..eec9738 100644
--- a/drivers/pci/setup-irq.c
+++ b/drivers/pci/setup-irq.c
@@ -59,7 +59,6 @@ pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *),
int (*map_irq)(struct pci_dev *, u8, u8))
{
struct pci_dev *dev = NULL;
- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
+ for_each_pci_dev(dev)
pdev_fixup_irq(dev, swizzle, map_irq);
- }
}
--
1.7.0.4

2010-07-30 16:48:42

by Jesse Barnes

Subject: Re: [PATCH 17/19] drivers/pci: use for_each_pci_dev()

On Sat, 3 Jul 2010 20:04:39 +0400
Kulikov Vasiliy <[email protected]> wrote:

> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> drivers/pci/setup-irq.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
> index aa795fd..eec9738 100644
> --- a/drivers/pci/setup-irq.c
> +++ b/drivers/pci/setup-irq.c
> @@ -59,7 +59,6 @@ pci_fixup_irqs(u8 (*swizzle)(struct pci_dev *, u8 *),
> int (*map_irq)(struct pci_dev *, u8, u8))
> {
> struct pci_dev *dev = NULL;
> - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> + for_each_pci_dev(dev)
> pdev_fixup_irq(dev, swizzle, map_irq);
> - }
> }

Applied all of these to my linux-next branch. I squashed all the PCI
ones into a single commit, keeping only the x86 one separate.

--
Jesse Barnes, Intel Open Source Technology Center