2010-07-30 02:59:34

by Axel Lin

Subject: [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static

The following symbols are needlessly defined global:
jornada_bl_init
jornada_bl_exit
jornada_lcd_init
jornada_lcd_exit

This patch makes the symbols static.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/video/backlight/jornada720_bl.c | 4 ++--
drivers/video/backlight/jornada720_lcd.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
index 60e1d28..a20a01a 100644
--- a/drivers/video/backlight/jornada720_bl.c
+++ b/drivers/video/backlight/jornada720_bl.c
@@ -146,12 +146,12 @@ static struct platform_driver jornada_bl_driver = {
},
};

-int __init jornada_bl_init(void)
+static int __init jornada_bl_init(void)
{
return platform_driver_register(&jornada_bl_driver);
}

-void __exit jornada_bl_exit(void)
+static void __exit jornada_bl_exit(void)
{
platform_driver_unregister(&jornada_bl_driver);
}
diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
index 8fe0181..9fd7af2 100644
--- a/drivers/video/backlight/jornada720_lcd.c
+++ b/drivers/video/backlight/jornada720_lcd.c
@@ -135,12 +135,12 @@ static struct platform_driver jornada_lcd_driver = {
},
};

-int __init jornada_lcd_init(void)
+static int __init jornada_lcd_init(void)
{
return platform_driver_register(&jornada_lcd_driver);
}

-void __exit jornada_lcd_exit(void)
+static void __exit jornada_lcd_exit(void)
{
platform_driver_unregister(&jornada_lcd_driver);
}
--
1.5.4.3

2010-07-30 19:04:25

by Kristoffer Ericson

Subject: Re: [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static

On Fri, Jul 30, 2010 at 11:00:23AM +0800, Axel Lin wrote:
> The following symbols are needlessly defined global:
> jornada_bl_init
> jornada_bl_exit
> jornada_lcd_init
> jornada_lcd_exit
>
> This patch makes the symbols static.

Acked-by: Kristoffer Ericson <[email protected]>
Thx.

>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/video/backlight/jornada720_bl.c | 4 ++--
> drivers/video/backlight/jornada720_lcd.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
> index 60e1d28..a20a01a 100644
> --- a/drivers/video/backlight/jornada720_bl.c
> +++ b/drivers/video/backlight/jornada720_bl.c
> @@ -146,12 +146,12 @@ static struct platform_driver jornada_bl_driver = {
> },
> };
>
> -int __init jornada_bl_init(void)
> +static int __init jornada_bl_init(void)
> {
> return platform_driver_register(&jornada_bl_driver);
> }
>
> -void __exit jornada_bl_exit(void)
> +static void __exit jornada_bl_exit(void)
> {
> platform_driver_unregister(&jornada_bl_driver);
> }
> diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> index 8fe0181..9fd7af2 100644
> --- a/drivers/video/backlight/jornada720_lcd.c
> +++ b/drivers/video/backlight/jornada720_lcd.c
> @@ -135,12 +135,12 @@ static struct platform_driver jornada_lcd_driver = {
> },
> };
>
> -int __init jornada_lcd_init(void)
> +static int __init jornada_lcd_init(void)
> {
> return platform_driver_register(&jornada_lcd_driver);
> }
>
> -void __exit jornada_lcd_exit(void)
> +static void __exit jornada_lcd_exit(void)
> {
> platform_driver_unregister(&jornada_lcd_driver);
> }
> --
> 1.5.4.3
>
>