2010-08-12 19:27:23

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH -next] optprobes: fix kconfig depends/selects

From: Randy Dunlap <[email protected]>

KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.

warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Ananth N Mavinakayanahalli <[email protected]>
Cc: Anil S Keshavamurthy <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
---
arch/Kconfig | 2 ++
1 file changed, 2 insertions(+)

--- linux-next-20100810.orig/arch/Kconfig
+++ linux-next-20100810/arch/Kconfig
@@ -45,6 +45,8 @@ config OPTPROBES
def_bool y
depends on KPROBES && HAVE_OPTPROBES
depends on !PREEMPT
+ depends on DEBUG_KERNEL
+ select KALLSYMS
select KALLSYMS_ALL

config HAVE_EFFICIENT_UNALIGNED_ACCESS


Subject: Re: [PATCH -next] optprobes: fix kconfig depends/selects

Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.

Indeed, Thanks for pointing it!

Signed-off-by: Masami Hiramatsu <[email protected]>

>
> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Ananth N Mavinakayanahalli <[email protected]>
> Cc: Anil S Keshavamurthy <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Masami Hiramatsu <[email protected]>
> ---
> arch/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20100810.orig/arch/Kconfig
> +++ linux-next-20100810/arch/Kconfig
> @@ -45,6 +45,8 @@ config OPTPROBES
> def_bool y
> depends on KPROBES && HAVE_OPTPROBES
> depends on !PREEMPT
> + depends on DEBUG_KERNEL
> + select KALLSYMS
> select KALLSYMS_ALL
>
> config HAVE_EFFICIENT_UNALIGNED_ACCESS

Subject: Re: [PATCH -next] optprobes: fix kconfig depends/selects

Masami Hiramatsu wrote:
> Randy Dunlap wrote:
>> From: Randy Dunlap <[email protected]>
>>
>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>
> Indeed, Thanks for pointing it!
>
> Signed-off-by: Masami Hiramatsu <[email protected]>

Oops, I meant;
Acked-by: Masami Hiramatsu <[email protected]>

Sorry:(
>
>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Ananth N Mavinakayanahalli <[email protected]>
>> Cc: Anil S Keshavamurthy <[email protected]>
>> Cc: "David S. Miller" <[email protected]>
>> Cc: Masami Hiramatsu <[email protected]>
>> ---
>> arch/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> --- linux-next-20100810.orig/arch/Kconfig
>> +++ linux-next-20100810/arch/Kconfig
>> @@ -45,6 +45,8 @@ config OPTPROBES
>> def_bool y
>> depends on KPROBES && HAVE_OPTPROBES
>> depends on !PREEMPT
>> + depends on DEBUG_KERNEL
>> + select KALLSYMS
>> select KALLSYMS_ALL
>>
>> config HAVE_EFFICIENT_UNALIGNED_ACCESS
>
>