2010-08-17 08:51:49

by Hiremath, Vaibhav

Subject: [PATCH 3/3] RTC:s35390a: Add update_irq (per Min interrupt) support

From: Vaibhav Hiremath <[email protected]>


Signed-off-by: Vaibhav Hiremath <[email protected]>
---
drivers/rtc/rtc-s35390a.c | 30 ++++++++++++++++++++++++++++++
1 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c
index d456b70..a6b0412 100644
--- a/drivers/rtc/rtc-s35390a.c
+++ b/drivers/rtc/rtc-s35390a.c
@@ -391,6 +391,35 @@ static int s35390a_rtc_set_irq_freq(struct device *dev, int freq)
return s35390a_set_irq_freq(to_i2c_client(dev), freq);
}

+static int s35390a_update_irq_enable(struct i2c_client *client,
+ unsigned enabled)
+{
+ struct s35390a *s35390a = i2c_get_clientdata(client);
+ char buf[1];
+
+ if (s35390a_get_reg(s35390a, S35390A_CMD_STATUS2, buf, sizeof(buf)) < 0)
+ return -EIO;
+
+ /* This chip returns the bits of each byte in reverse order */
+ buf[0] = bitrev8(buf[0]);
+
+ buf[0] &= ~S35390A_INT1_MODE_MASK;
+ if (enabled)
+ buf[0] |= S35390A_INT1_MODE_PMIN_EDG;
+ else
+ buf[0] |= S35390A_INT1_MODE_NOINTR;
+
+ /* This chip expects the bits of each byte in reverse order */
+ buf[0] = bitrev8(buf[0]);
+
+ return s35390a_set_reg(s35390a, S35390A_CMD_STATUS2, buf, sizeof(buf));
+}
+
+static int s35390a_rtc_update_irq_enable(struct device *dev, unsigned enabled)
+{
+ return s35390a_update_irq_enable(to_i2c_client(dev), enabled);
+}
+
static void s35390a_work(struct work_struct *work)
{
struct s35390a *s35390a;
@@ -445,6 +474,7 @@ static const struct rtc_class_ops s35390a_rtc_ops = {
.read_alarm = s35390a_rtc_read_alarm,
.irq_set_freq = s35390a_rtc_set_irq_freq,
.irq_set_state = s35390a_rtc_freq_irq_enable,
+ .update_irq_enable = s35390a_rtc_update_irq_enable,
};

static struct i2c_driver s35390a_driver;
--
1.6.2.4

2010-08-17 09:29:54

by Felipe Balbi

Subject: Re: [PATCH 3/3] RTC:s35390a: Add update_irq (per Min interrupt) support

On Tue, Aug 17, 2010 at 10:48:41AM +0200, ext [email protected] wrote:
>From: Vaibhav Hiremath <[email protected]>

description

>Signed-off-by: Vaibhav Hiremath <[email protected]>

--
balbi

DefectiveByDesign.org