2010-08-18 15:19:06

by Minchan Kim

[permalink] [raw]
Subject: android-kernel memory reclaim x20 boost?

Hello Android forks,

I could have a question in android kernel mailing list.
But I think many mm guys in linux-mm also might have a interest in it.
So I send a question in linux-mm mailing list.

I saw the advertisement phrase in this[1].

"Kernel Memory Management Boost: Improved memory reclaim by up to 20x,
which results in faster app switching and smoother performance
on memory-constrained devices."

But I can't find any code for it in android kernel git tree.
If it's your private patch, could you explan what kinds of feature can enhance
it by up to 20x?

If it is really good, we can merge it to mainline.

[1] http://developer.android.com/sdk/android-2.2-highlights.html

--
Kind regards,
Minchan Kim


Subject: Re: android-kernel memory reclaim x20 boost?

El Thu, 19 Aug 2010 00:18:57 +0900
Minchan Kim <[email protected]> escribió:

> Hello Android forks,
[ ... ]
>
> I saw the advertisement phrase in this[1].
>
> "Kernel Memory Management Boost: Improved memory reclaim by up to 20x,
> which results in faster app switching and smoother performance
> on memory-constrained devices."
>
> But I can't find any code for it in android kernel git tree.

Maybe the enhancements are on the Dalvik VM (shooting in the dark here)

> If it's your private patch, could you explan what kinds of feature can enhance
> it by up to 20x?
>
> If it is really good, we can merge it to mainline.
>
> [1] http://developer.android.com/sdk/android-2.2-highlights.html
>

2010-08-19 01:02:02

by Arve Hjønnevåg

[permalink] [raw]
Subject: Re: android-kernel memory reclaim x20 boost?

On Wed, Aug 18, 2010 at 5:54 PM, Minchan Kim <[email protected]> wrote:
> On Thu, Aug 19, 2010 at 12:26 AM, Alejandro Riveira Fern?ndez
> <[email protected]> wrote:
>> El Thu, 19 Aug 2010 00:18:57 +0900
>> Minchan Kim <[email protected]> escribi?:
>>
>>> Hello Android forks,
>> [ ... ]
>>>
>>> I saw the advertisement phrase in this[1].
>>>
>>> "Kernel Memory Management Boost: Improved memory reclaim by up to 20x,
>>> which results in faster app switching and smoother performance
>>> on memory-constrained devices."
>>>
>>> But I can't find any code for it in android kernel git tree.
>>
>> ?Maybe the enhancements are on the Dalvik VM (shooting in the dark here)
>
> Thanks.
> Android guys! Could you confirm this?
>

It is more likely referring to this change:

Author: San Mehat <[email protected]>
Date: Wed May 5 11:38:42 2010 -0700

staging: android: lowmemkiller: Substantially reduce overhead during reclaim

This patch optimizes lowmemkiller to not do any work when it has
an outstanding
kill-request. This greatly reduces the pressure on the task_list lock
(improving interactivity), as well as improving the vmscan performance
when under heavy memory pressure (by up to 20x in tests).

Note: For this enhancement to work, you need CONFIG_PROFILING

Signed-off-by: San Mehat <[email protected]>


--
Arve Hj?nnev?g

2010-08-19 01:04:09

by San Mehat

[permalink] [raw]
Subject: Re: android-kernel memory reclaim x20 boost?

On Wed, Aug 18, 2010 at 6:01 PM, Arve Hj?nnev?g <[email protected]> wrote:
> On Wed, Aug 18, 2010 at 5:54 PM, Minchan Kim <[email protected]> wrote:
>> On Thu, Aug 19, 2010 at 12:26 AM, Alejandro Riveira Fern?ndez
>> <[email protected]> wrote:
>>> El Thu, 19 Aug 2010 00:18:57 +0900
>>> Minchan Kim <[email protected]> escribi?:
>>>
>>>> Hello Android forks,
>>> [ ... ]
>>>>
>>>> I saw the advertisement phrase in this[1].
>>>>
>>>> "Kernel Memory Management Boost: Improved memory reclaim by up to 20x,
>>>> which results in faster app switching and smoother performance
>>>> on memory-constrained devices."
>>>>
>>>> But I can't find any code for it in android kernel git tree.
>>>
>>> ?Maybe the enhancements are on the Dalvik VM (shooting in the dark here)
>>
>> Thanks.
>> Android guys! Could you confirm this?
>>
>
> It is more likely referring to this change:
>

There are other changes after the one mentioned that remove the
requirement for CONFIG_PROFILING
(and the subsequent task_struct leak that was caused by it)

-san

> Author: San Mehat <[email protected]>
> Date: ? Wed May 5 11:38:42 2010 -0700
>
> ? ?staging: android: lowmemkiller: Substantially reduce overhead during reclaim
>
> ? ?This patch optimizes lowmemkiller to not do any work when it has
> an outstanding
> ? ?kill-request. This greatly reduces the pressure on the task_list lock
> ? ?(improving interactivity), as well as improving the vmscan performance
> ? ?when under heavy memory pressure (by up to 20x in tests).
>
> ? ?Note: For this enhancement to work, you need CONFIG_PROFILING
>
> ? ?Signed-off-by: San Mehat <[email protected]>
>
>
> --
> Arve Hj?nnev?g
>



--
San Mehat ?| ?Staff Software Engineer ?| ?Infrastructure ?| ?Google Inc.
415.366.6172 ([email protected])

2010-08-19 13:26:35

by Minchan Kim

[permalink] [raw]
Subject: Re: android-kernel memory reclaim x20 boost?

On Thu, Aug 19, 2010 at 10:04 AM, San Mehat <[email protected]> wrote:
> On Wed, Aug 18, 2010 at 6:01 PM, Arve Hj?nnev?g <[email protected]> wrote:
>> On Wed, Aug 18, 2010 at 5:54 PM, Minchan Kim <[email protected]> wrote:
>>> On Thu, Aug 19, 2010 at 12:26 AM, Alejandro Riveira Fern?ndez
>>> <[email protected]> wrote:
>>>> El Thu, 19 Aug 2010 00:18:57 +0900
>>>> Minchan Kim <[email protected]> escribi?:
>>>>
>>>>> Hello Android forks,
>>>> [ ... ]
>>>>>
>>>>> I saw the advertisement phrase in this[1].
>>>>>
>>>>> "Kernel Memory Management Boost: Improved memory reclaim by up to 20x,
>>>>> which results in faster app switching and smoother performance
>>>>> on memory-constrained devices."
>>>>>
>>>>> But I can't find any code for it in android kernel git tree.
>>>>
>>>> ?Maybe the enhancements are on the Dalvik VM (shooting in the dark here)
>>>
>>> Thanks.
>>> Android guys! Could you confirm this?
>>>
>>
>> It is more likely referring to this change:
>>
>
> There are other changes after the one mentioned that remove the
> requirement for CONFIG_PROFILING
> (and the subsequent task_struct leak that was caused by it)
>
> -san

It seems to be not a issue of mainline but only one of android lowmemkiller.
Thanks for the information, Android forks.


--
Kind regards,
Minchan Kim

2010-08-19 13:59:35

by Minchan Kim

[permalink] [raw]
Subject: Re: android-kernel memory reclaim x20 boost?

On Thu, Aug 19, 2010 at 12:26 AM, Alejandro Riveira Fern?ndez
<[email protected]> wrote:
> El Thu, 19 Aug 2010 00:18:57 +0900
> Minchan Kim <[email protected]> escribi?:
>
>> Hello Android forks,
> [ ... ]
>>
>> I saw the advertisement phrase in this[1].
>>
>> "Kernel Memory Management Boost: Improved memory reclaim by up to 20x,
>> which results in faster app switching and smoother performance
>> on memory-constrained devices."
>>
>> But I can't find any code for it in android kernel git tree.
>
> ?Maybe the enhancements are on the Dalvik VM (shooting in the dark here)

Thanks.
Android guys! Could you confirm this?


--
Kind regards,
Minchan Kim