2010-08-23 11:33:23

by Carlos Mafra

[permalink] [raw]
Subject: 2.6.36-rc2 drm compilation failure

The compilation of 2.6.36-rc2 fails with the following error

LD .tmp_vmlinux1
drivers/built-in.o: In function `vga_get_uninterruptible':
/home/mafra/linux-2.6/include/linux/vgaarb.h:120: undefined reference to `vga_get'
drivers/built-in.o: In function `i915_disable_vga':
/home/mafra/linux-2.6/drivers/gpu/drm/i915/intel_display.c:5990: undefined reference to `vga_put'
make[1]: *** [.tmp_vmlinux1] Fehler 1
make: *** [sub-make] Fehler 2

but 2.6.36-rc1 compiled fine.

The machine is a Vaio 64-bit laptop with

VGA compatible controller: Intel Corporation Mobile GM965/GL960 Integrated Graphics Controller

and my .config has

CONFIG_DRM_I915=y
CONFIG_DRM_I915_KMS=y

but also

# CONFIG_VGA_ARB is not set

I guess the following commit introduced the error 9cce37f4855a30cc
("drm/i915: fix VGA plane disable for Ironlake+").

If there's any other information I should provide, please let me know.


2010-08-23 15:48:43

by Jesse Barnes

[permalink] [raw]
Subject: Re: 2.6.36-rc2 drm compilation failure

On Mon, 23 Aug 2010 13:32:48 +0200
"Carlos R. Mafra" <[email protected]> wrote:

> The compilation of 2.6.36-rc2 fails with the following error
>
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `vga_get_uninterruptible':
> /home/mafra/linux-2.6/include/linux/vgaarb.h:120: undefined reference to `vga_get'
> drivers/built-in.o: In function `i915_disable_vga':
> /home/mafra/linux-2.6/drivers/gpu/drm/i915/intel_display.c:5990: undefined reference to `vga_put'
> make[1]: *** [.tmp_vmlinux1] Fehler 1
> make: *** [sub-make] Fehler 2
>
> but 2.6.36-rc1 compiled fine.
>
> The machine is a Vaio 64-bit laptop with
>
> VGA compatible controller: Intel Corporation Mobile GM965/GL960 Integrated Graphics Controller
>
> and my .config has
>
> CONFIG_DRM_I915=y
> CONFIG_DRM_I915_KMS=y
>
> but also
>
> # CONFIG_VGA_ARB is not set
>
> I guess the following commit introduced the error 9cce37f4855a30cc
> ("drm/i915: fix VGA plane disable for Ironlake+").
>
> If there's any other information I should provide, please let me know.

Ah so we need to select VGA arb or make sure stubs are provided
for !VGA_ARB configs.

--
Jesse Barnes, Intel Open Source Technology Center

2010-08-23 23:22:45

by Jesse Barnes

[permalink] [raw]
Subject: Re: 2.6.36-rc2 drm compilation failure

On Mon, 23 Aug 2010 13:32:48 +0200
"Carlos R. Mafra" <[email protected]> wrote:

> The compilation of 2.6.36-rc2 fails with the following error
>
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `vga_get_uninterruptible':
> /home/mafra/linux-2.6/include/linux/vgaarb.h:120: undefined reference to `vga_get'
> drivers/built-in.o: In function `i915_disable_vga':
> /home/mafra/linux-2.6/drivers/gpu/drm/i915/intel_display.c:5990: undefined reference to `vga_put'
> make[1]: *** [.tmp_vmlinux1] Fehler 1
> make: *** [sub-make] Fehler 2
>
> but 2.6.36-rc1 compiled fine.
>
> The machine is a Vaio 64-bit laptop with
>
> VGA compatible controller: Intel Corporation Mobile GM965/GL960 Integrated Graphics Controller
>
> and my .config has
>
> CONFIG_DRM_I915=y
> CONFIG_DRM_I915_KMS=y
>
> but also
>
> # CONFIG_VGA_ARB is not set
>
> I guess the following commit introduced the error 9cce37f4855a30cc
> ("drm/i915: fix VGA plane disable for Ironlake+").
>
> If there's any other information I should provide, please let me know.

Oh I see Chris already posted a patch for this. Should be upstream
soon.

--
Jesse Barnes, Intel Open Source Technology Center

2010-08-23 23:50:33

by Carlos Mafra

[permalink] [raw]
Subject: Re: 2.6.36-rc2 drm compilation failure

On Mo 23.Aug'10 at 16:22:41 -0700, Jesse Barnes wrote:

> Oh I see Chris already posted a patch for this. Should be upstream
> soon.

Ok, I will wait then. Thanks for letting me know!