2010-08-06 02:28:05

by Joonyoung Shim

Subject: [PATCH v3 0/3] MAX8998 changes for RTC

Hi.

This patchset is to support the RTC provided by the Maxim 8998 chip. For
this first, needs i2c interface changes and interrupts support of
max8998 mfd driver.

Changes since v1:
- Fix missing braces of 3/3 patch from v1 review.
- The rest is same with v1.

Changes since v2:
- add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
- The rest is same with v2.

Joonyoung Shim (3):
mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
mfd: MAX8998: Add interrupts support
rtc: Add MAX8998 rtc driver

drivers/mfd/Kconfig | 2 +-
drivers/mfd/Makefile | 2 +-
drivers/mfd/max8998-irq.c | 255 +++++++++++++++++++++++++++++
drivers/mfd/max8998.c | 78 +++++++--
drivers/regulator/max8998.c | 17 ++-
drivers/rtc/Kconfig | 10 ++
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-max8998.c | 300 +++++++++++++++++++++++++++++++++++
include/linux/mfd/max8998-private.h | 106 +++++++++---
include/linux/mfd/max8998.h | 11 +-
10 files changed, 726 insertions(+), 56 deletions(-)
create mode 100644 drivers/mfd/max8998-irq.c
create mode 100644 drivers/rtc/rtc-max8998.c

2010-08-25 08:55:05

by Joonyoung Shim

Subject: Re: [PATCH v3 0/3] MAX8998 changes for RTC

2010/8/6 Joonyoung Shim <[email protected]>:
> Hi.
>
> This patchset is to support the RTC provided by the Maxim 8998 chip. For
> this first, needs i2c interface changes and interrupts support of
> max8998 mfd driver.
>
> Changes since v1:
> ?- Fix missing braces of 3/3 patch from v1 review.
> ?- The rest is same with v1.
>
> Changes since v2:
> ?- add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
> ?- The rest is same with v2.
>
> Joonyoung Shim (3):
> ? ? ?mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
> ? ? ?mfd: MAX8998: Add interrupts support
> ? ? ?rtc: Add MAX8998 rtc driver
>

Ping. Is there any feedback?

Thanks.

--
- Joonyoung Shim

2010-08-25 19:22:28

by Andrew Morton

Subject: Re: [PATCH v3 0/3] MAX8998 changes for RTC

On Wed, 25 Aug 2010 17:55:00 +0900
Joonyoung Shim <[email protected]> wrote:

> 2010/8/6 Joonyoung Shim <[email protected]>:
> > Hi.
> >
> > This patchset is to support the RTC provided by the Maxim 8998 chip. For
> > this first, needs i2c interface changes and interrupts support of
> > max8998 mfd driver.
> >
> > Changes since v1:
> > - Fix missing braces of 3/3 patch from v1 review.
> > - The rest is same with v1.
> >
> > Changes since v2:
> > - add missing free_irq and rtc_valid_tm on rtc driver of 3/3 patch
> > - The rest is same with v2.
> >
> > Joonyoung Shim (3):
> > mfd: MAX8998: Use struct i2c_client to argument on i2c operation functions
> > mfd: MAX8998: Add interrupts support
> > rtc: Add MAX8998 rtc driver
> >
>
> Ping. Is there any feedback?

They look good to me. Things are pretty delayed at present as I (and
presumably others) recover from the -rc merge window..

I merged them. Sam's acks on the MFD bits made life easier.