2010-11-01 21:02:07

by Divy Le ray

Subject: [PATCH net-2.6 1/3] cxgb3: remove call to stop TX queues at load time.

From: Divy Le Ray <[email protected]>

Remove racy queue stopping after device registration.

Signed-off-by: Divy Le Ray <[email protected]>

---

drivers/net/cxgb3/cxgb3_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)


diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 407d4e2..046d846 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -3341,7 +3341,6 @@ static int __devinit init_one(struct pci_dev *pdev,
adapter->name = adapter->port[i]->name;

__set_bit(i, &adapter->registered_device_map);
- netif_tx_stop_all_queues(adapter->port[i]);
}
}
if (!adapter->registered_device_map) {

2010-11-01 21:02:11

by Divy Le ray

Subject: [PATCH net-2.6 2/3] cxgb4: remove call to stop TX queues at load time.

From: Divy Le Ray <[email protected]>

Remove racy queue stopping after device registration.

Signed-off-by: Dimitris Michailidis <[email protected]>

---

drivers/net/cxgb4/cxgb4_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)


diff --git a/drivers/net/cxgb4/cxgb4_main.c b/drivers/net/cxgb4/cxgb4_main.c
index f17703f..f50bc98 100644
--- a/drivers/net/cxgb4/cxgb4_main.c
+++ b/drivers/net/cxgb4/cxgb4_main.c
@@ -3736,7 +3736,6 @@ static int __devinit init_one(struct pci_dev *pdev,

__set_bit(i, &adapter->registered_device_map);
adapter->chan_map[adap2pinfo(adapter, i)->tx_chan] = i;
- netif_tx_stop_all_queues(adapter->port[i]);
}
}
if (!adapter->registered_device_map) {

2010-11-01 21:02:18

by Divy Le ray

Subject: [PATCH net-2.6 3/3] cxgb4vf: remove call to stop TX queues at load time.

From: Divy Le Ray <[email protected]>

Stopping TX queues at driver load time is not necessary.

Signed-off-by: Casey Leedom <[email protected]>

---

drivers/net/cxgb4vf/cxgb4vf_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)


diff --git a/drivers/net/cxgb4vf/cxgb4vf_main.c b/drivers/net/cxgb4vf/cxgb4vf_main.c
index 555ecc5..6de5e2e 100644
--- a/drivers/net/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/cxgb4vf/cxgb4vf_main.c
@@ -2600,7 +2600,6 @@ static int __devinit cxgb4vf_pci_probe(struct pci_dev *pdev,
pi->xact_addr_filt = -1;
pi->rx_offload = RX_CSO;
netif_carrier_off(netdev);
- netif_tx_stop_all_queues(netdev);
netdev->irq = pdev->irq;

netdev->features = (NETIF_F_SG | NETIF_F_TSO | NETIF_F_TSO6 |

2010-11-01 21:09:52

by David Miller

Subject: Re: [PATCH net-2.6 1/3] cxgb3: remove call to stop TX queues at load time.

From: Divy Le Ray <[email protected]>
Date: Mon, 01 Nov 2010 13:59:41 -0700

> From: Divy Le Ray <[email protected]>
>
> Remove racy queue stopping after device registration.
>
> Signed-off-by: Divy Le Ray <[email protected]>

Applied.

2010-11-01 21:09:57

by David Miller

Subject: Re: [PATCH net-2.6 2/3] cxgb4: remove call to stop TX queues at load time.

From: Divy Le Ray <[email protected]>
Date: Mon, 01 Nov 2010 13:59:46 -0700

> From: Divy Le Ray <[email protected]>
>
> Remove racy queue stopping after device registration.
>
> Signed-off-by: Dimitris Michailidis <[email protected]>

Applied.

2010-11-01 21:10:04

by David Miller

Subject: Re: [PATCH net-2.6 3/3] cxgb4vf: remove call to stop TX queues at load time.

From: Divy Le Ray <[email protected]>
Date: Mon, 01 Nov 2010 13:59:51 -0700

> From: Divy Le Ray <[email protected]>
>
> Stopping TX queues at driver load time is not necessary.
>
> Signed-off-by: Casey Leedom <[email protected]>

Applied.