This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the btusb
driver.
Signed-off-by: Edgar (gimli) Hucek <[email protected]>
Not sure of you guys monitor LKML...
On Tue, Nov 02, 2010 at 08:19:43AM +0100, gimli wrote:
> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the btusb
> driver.
>
> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
> --- a/drivers/bluetooth/btusb.c 2010-10-30 21:08:45.170492002 +0200
> +++ b/drivers/bluetooth/btusb.c 2010-10-30 21:18:11.820492000 +0200
> @@ -62,6 +62,9 @@
> /* Apple iMac11,1 */
> { USB_DEVICE(0x05ac, 0x8215) },
>
> + /* Apple MacBookAir3,1, MacBookAir3,2 */
> + { USB_DEVICE(0x05ac, 0x821b) },
> +
> /* AVM BlueFRITZ! USB v2.0 */
> { USB_DEVICE(0x057c, 0x3800) },
>
--
Dmitry
Hi Dmitry,
> Not sure of you guys monitor LKML...
not on a regular basis.
> > This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the btusb
> > driver.
> >
> > Signed-off-by: Edgar (gimli) Hucek <[email protected]>
>
> > --- a/drivers/bluetooth/btusb.c 2010-10-30 21:08:45.170492002 +0200
> > +++ b/drivers/bluetooth/btusb.c 2010-10-30 21:18:11.820492000 +0200
> > @@ -62,6 +62,9 @@
> > /* Apple iMac11,1 */
> > { USB_DEVICE(0x05ac, 0x8215) },
> >
> > + /* Apple MacBookAir3,1, MacBookAir3,2 */
> > + { USB_DEVICE(0x05ac, 0x821b) },
> > +
> > /* AVM BlueFRITZ! USB v2.0 */
> > { USB_DEVICE(0x057c, 0x3800) },
patch looks fine to me, but it should be send to linux-bluetooth mailing
list.
Acked-by: Marcel Holtmann <[email protected]>
Regards
Marcel
Hi Edgar,
* Marcel Holtmann <[email protected]> [2010-11-02 16:38:02 +0100]:
> Hi Dmitry,
>
> > Not sure of you guys monitor LKML...
>
> not on a regular basis.
>
> > > This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the btusb
> > > driver.
> > >
> > > Signed-off-by: Edgar (gimli) Hucek <[email protected]>
Please also provide the output of usb-devices for this hardware in
commit message when resubmitting the patch.
> >
> > > --- a/drivers/bluetooth/btusb.c 2010-10-30 21:08:45.170492002 +0200
> > > +++ b/drivers/bluetooth/btusb.c 2010-10-30 21:18:11.820492000 +0200
> > > @@ -62,6 +62,9 @@
> > > /* Apple iMac11,1 */
> > > { USB_DEVICE(0x05ac, 0x8215) },
> > >
> > > + /* Apple MacBookAir3,1, MacBookAir3,2 */
> > > + { USB_DEVICE(0x05ac, 0x821b) },
> > > +
> > > /* AVM BlueFRITZ! USB v2.0 */
> > > { USB_DEVICE(0x057c, 0x3800) },
>
> patch looks fine to me, but it should be send to linux-bluetooth mailing
> list.
>
> Acked-by: Marcel Holtmann <[email protected]>
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
Hi,
in what form i should provide it ?
cu
Edgar (gimli) Hucek
Am 03.11.10 19:21, schrieb Gustavo F. Padovan:
> Hi Edgar,
>
> * Marcel Holtmann<[email protected]> [2010-11-02 16:38:02 +0100]:
>
>> Hi Dmitry,
>>
>>> Not sure of you guys monitor LKML...
>>
>> not on a regular basis.
>>
>>>> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the btusb
>>>> driver.
>>>>
>>>> Signed-off-by: Edgar (gimli) Hucek<[email protected]>
>
> Please also provide the output of usb-devices for this hardware in
> commit message when resubmitting the patch.
>
>>>
>>>> --- a/drivers/bluetooth/btusb.c 2010-10-30 21:08:45.170492002 +0200
>>>> +++ b/drivers/bluetooth/btusb.c 2010-10-30 21:18:11.820492000 +0200
>>>> @@ -62,6 +62,9 @@
>>>> /* Apple iMac11,1 */
>>>> { USB_DEVICE(0x05ac, 0x8215) },
>>>>
>>>> + /* Apple MacBookAir3,1, MacBookAir3,2 */
>>>> + { USB_DEVICE(0x05ac, 0x821b) },
>>>> +
>>>> /* AVM BlueFRITZ! USB v2.0 */
>>>> { USB_DEVICE(0x057c, 0x3800) },
>>
>> patch looks fine to me, but it should be send to linux-bluetooth mailing
>> list.
>>
>> Acked-by: Marcel Holtmann<[email protected]>
>
Hi Gimli,
We don't allow top posting in this mailing, please keep that in mind
next time. Thanks.
* gimli <[email protected]> [2010-11-03 20:07:56 +0100]:
> Hi,
>
> in what form i should provide it ?
This is a example:
commit 3cd01976e702ccaffb907727caff4f8789353599
Author: Nobuhiro Iwamatsu <[email protected]>
Date: Fri Aug 20 16:24:07 2010 +0900
Bluetooth: Add support Bluetooth controller of MacbookPro 7,1
Bluetooth controller of MacbookPro 7,1 does not work.
Because Device Class of these controllers was set 255 (Vendor Sepecific Class).
T: Bus=04 Lev=02 Prnt=04 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=05ac ProdID=8213 Rev=01.86
S: Manufacturer=Apple Inc.
S: Product=Bluetooth USB Host Controller
S: SerialNumber=5C5948C81B99
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=00 Driver=(none)
Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
Acked-by: Marcel Holtmann <[email protected]>
Signed-off-by: Gustavo F. Padovan <[email protected]>
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
Here is the output :
T: Bus=03 Lev=02 Prnt=03 Port=02 Cnt=01 Dev#= 6 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=05ac ProdID=821b Rev= 0.34
S: Manufacturer=Apple Inc.
S: Product=Bluetooth USB Host Controller
C:* #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr= 0mA
I:* If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 32 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 32 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 64 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 64 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=83(I) Atr=01(Isoc) MxPS= 64 Ivl=1ms
E: Ad=03(O) Atr=01(Isoc) MxPS= 64 Ivl=1ms
I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E: Ad=84(I) Atr=02(Bulk) MxPS= 32 Ivl=0ms
E: Ad=04(O) Atr=02(Bulk) MxPS= 32 Ivl=0ms
I:* If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Am 03.11.10 20:14, schrieb Gustavo F. Padovan:
> Hi Gimli,
>
> We don't allow top posting in this mailing, please keep that in mind
> next time. Thanks.
>
> * gimli<[email protected]> [2010-11-03 20:07:56 +0100]:
>
>> Hi,
>>
>> in what form i should provide it ?
>
>
> This is a example:
>
> commit 3cd01976e702ccaffb907727caff4f8789353599
> Author: Nobuhiro Iwamatsu<[email protected]>
> Date: Fri Aug 20 16:24:07 2010 +0900
>
> Bluetooth: Add support Bluetooth controller of MacbookPro 7,1
>
> Bluetooth controller of MacbookPro 7,1 does not work.
> Because Device Class of these controllers was set 255 (Vendor Sepecific Class).
>
> T: Bus=04 Lev=02 Prnt=04 Port=00 Cnt=01 Dev#= 5 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=05ac ProdID=8213 Rev=01.86
> S: Manufacturer=Apple Inc.
> S: Product=Bluetooth USB Host Controller
> S: SerialNumber=5C5948C81B99
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=00 Driver=(none)
>
> Signed-off-by: Nobuhiro Iwamatsu<[email protected]>
> Acked-by: Marcel Holtmann<[email protected]>
> Signed-off-by: Gustavo F. Padovan<[email protected]>
>
Hi Gimli,
Again, please stop top posting, it's not accepted here.
* gimli <[email protected]> [2010-11-03 21:19:49 +0100]:
> Here is the output :
>
> T: Bus=03 Lev=02 Prnt=03 Port=02 Cnt=01 Dev#= 6 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=05ac ProdID=821b Rev= 0.34
> S: Manufacturer=Apple Inc.
> S: Product=Bluetooth USB Host Controller
> C:* #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr= 0mA
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
> E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
> E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
> E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
> I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
> I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 32 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 32 Ivl=1ms
> I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 64 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 64 Ivl=1ms
> I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=83(I) Atr=01(Isoc) MxPS= 64 Ivl=1ms
> E: Ad=03(O) Atr=01(Isoc) MxPS= 64 Ivl=1ms
> I:* If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> E: Ad=84(I) Atr=02(Bulk) MxPS= 32 Ivl=0ms
> E: Ad=04(O) Atr=02(Bulk) MxPS= 32 Ivl=0ms
> I:* If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Actually you have to post the output of usb-devices without your patch
to show why your patch need is needed. And you should add that to the
commit message and resend your patch to linux-bluetooth instead of
posting it on this thread.
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi