On Sun, Oct 31, 2010 at 03:50:26AM -0400, Henrik Rydberg wrote:
> The amount of machines supported by this driver has increased rapidly
> over the past years, and the detailed driver support of the many
> flavors is quickly becoming a problem.
>
> This patchset introduces dynamic configuration by making the SMC
> register set efficiently searchable, and fixes a number of outstanding
> issues:
>
> * Support for all new models since MacbookPro 6.
> * Support for variable number of cpu sensors in the MacPros.
> * Handles the odd temperature sensor types found on new models.
> * Fixes minor read problems on many intermediate models.
>
> The first patch is preparatory. The second patch adds the register
> lookup cache. The third patch adds the dynamic temperature files, and
> the fourth implements a new temperature register format. The fifth
> patch makes the remaining features dynamically configured, and the
> sixth patch sets up the fans dynamically. The seventh patch is purely
> janitory, and the last patch updates the copyright.
>
> As a side-effect, the file is reduced by almost five hundred lines.
>
Henrik,
since you applied your changes on top of Joe's pr_fmt patch, I assume
that you Ack that patch. Is that a correct assumption ?
I know you sent an Ack earlier, but it was "except for comments already made",
so this is just for clarification.
Thanks,
Guenter
On 11/03/2010 02:48 PM, Guenter Roeck wrote:
> On Sun, Oct 31, 2010 at 03:50:26AM -0400, Henrik Rydberg wrote:
>> The amount of machines supported by this driver has increased rapidly
>> over the past years, and the detailed driver support of the many
>> flavors is quickly becoming a problem.
>>
>> This patchset introduces dynamic configuration by making the SMC
>> register set efficiently searchable, and fixes a number of outstanding
>> issues:
>>
>> * Support for all new models since MacbookPro 6.
>> * Support for variable number of cpu sensors in the MacPros.
>> * Handles the odd temperature sensor types found on new models.
>> * Fixes minor read problems on many intermediate models.
>>
>> The first patch is preparatory. The second patch adds the register
>> lookup cache. The third patch adds the dynamic temperature files, and
>> the fourth implements a new temperature register format. The fifth
>> patch makes the remaining features dynamically configured, and the
>> sixth patch sets up the fans dynamically. The seventh patch is purely
>> janitory, and the last patch updates the copyright.
>>
>> As a side-effect, the file is reduced by almost five hundred lines.
>>
> Henrik,
>
> since you applied your changes on top of Joe's pr_fmt patch, I assume
> that you Ack that patch. Is that a correct assumption ?
>
> I know you sent an Ack earlier, but it was "except for comments already made",
> so this is just for clarification.
Yeah, I'm good with those changes. As far as I understand, the issue was
regarding the extra define at the top, not the changes per se. I can certainly
live with that extra line until something better comes along.
Thanks,
Henrik