Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <[email protected]>
---
drivers/block/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/Makefile b/drivers/block/Makefile
index d7f463d..40528ba 100644
--- a/drivers/block/Makefile
+++ b/drivers/block/Makefile
@@ -39,4 +39,4 @@ obj-$(CONFIG_XEN_BLKDEV_FRONTEND) += xen-blkfront.o
obj-$(CONFIG_BLK_DEV_DRBD) += drbd/
obj-$(CONFIG_BLK_DEV_RBD) += rbd.o
-swim_mod-objs := swim.o swim_asm.o
+swim_mod-y := swim.o swim_asm.o
--
1.7.3.2.146.gca209
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <[email protected]>
---
drivers/block/aoe/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/Makefile b/drivers/block/aoe/Makefile
index e76d997..06ea82c 100644
--- a/drivers/block/aoe/Makefile
+++ b/drivers/block/aoe/Makefile
@@ -3,4 +3,4 @@
#
obj-$(CONFIG_ATA_OVER_ETH) += aoe.o
-aoe-objs := aoeblk.o aoechr.o aoecmd.o aoedev.o aoemain.o aoenet.o
+aoe-y := aoeblk.o aoechr.o aoecmd.o aoedev.o aoemain.o aoenet.o
--
1.7.3.2.146.gca209
On Nov 6, 2010, at 2:58 PM, Tracey Dent wrote:
> Changed <module>-objs to <module>-y in Makefile.
Andrew Morton, hi. I don't know whether Tracey Dent is expecting
me to push this change to Linus, but lately you've been pushing the
aoe changes. I see similar changes in other
drivers on the LKML, so if it looks good to you, would you mind please
picking up this patch?
> Signed-off-by: Tracey Dent <[email protected]>
> ---
> drivers/block/aoe/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/aoe/Makefile b/drivers/block/aoe/Makefile
> index e76d997..06ea82c 100644
> --- a/drivers/block/aoe/Makefile
> +++ b/drivers/block/aoe/Makefile
> @@ -3,4 +3,4 @@
> #
>
> obj-$(CONFIG_ATA_OVER_ETH) += aoe.o
> -aoe-objs := aoeblk.o aoechr.o aoecmd.o aoedev.o aoemain.o aoenet.o
> +aoe-y := aoeblk.o aoechr.o aoecmd.o aoedev.o aoemain.o aoenet.o
> --
> 1.7.3.2.146.gca209
>
--
Ed Cashin
[email protected]
On Mon, 8 Nov 2010 10:03:24 -0500
Ed Cashin <[email protected]> wrote:
> On Nov 6, 2010, at 2:58 PM, Tracey Dent wrote:
>
> > Changed <module>-objs to <module>-y in Makefile.
>
> Andrew Morton, hi. I don't know whether Tracey Dent is expecting
> me to push this change to Linus, but lately you've been pushing the
> aoe changes. I see similar changes in other
> drivers on the LKML, so if it looks good to you, would you mind please
> picking up this patch?
I queued both patches - I guess I'll send them to Jens.
I queued them as "unchangelogged patches". Because what the changelogs told
us was utterly obvious from reading the patch.
What the changelogs didn't tell us was _why_ the change was made. And
guess what? I don't have a clue! I just haven't been following these
kbuild minutea.
Tracey, please send a description of *why* this change is being made
and I'll add it to the changelogs. Please include that explanation in
all such patches.
Hi Ed,
On Mon, 8 Nov 2010 13:05:43 -0800 Andrew Morton <[email protected]> wrote:
>
> On Mon, 8 Nov 2010 10:03:24 -0500
> Ed Cashin <[email protected]> wrote:
>
> > On Nov 6, 2010, at 2:58 PM, Tracey Dent wrote:
> >
> > > Changed <module>-objs to <module>-y in Makefile.
> >
> > Andrew Morton, hi. I don't know whether Tracey Dent is expecting
> > me to push this change to Linus, but lately you've been pushing the
> > aoe changes. I see similar changes in other
> > drivers on the LKML, so if it looks good to you, would you mind please
> > picking up this patch?
>
> I queued both patches - I guess I'll send them to Jens.
I have a quilt series in linux-next called aoe that has not been updated
since Nov, 2009. Can I assume that it is defunct and remove it? Or will
you be using it again?
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On 11/8/10, Andrew Morton <[email protected]> wrote:
> On Mon, 8 Nov 2010 10:03:24 -0500
> Ed Cashin <[email protected]> wrote:
>
>> On Nov 6, 2010, at 2:58 PM, Tracey Dent wrote:
>>
>> > Changed <module>-objs to <module>-y in Makefile.
>>
>> Andrew Morton, hi. I don't know whether Tracey Dent is expecting
>> me to push this change to Linus, but lately you've been pushing the
>> aoe changes. I see similar changes in other
>> drivers on the LKML, so if it looks good to you, would you mind please
>> picking up this patch?
>
> I queued both patches - I guess I'll send them to Jens.
>
> I queued them as "unchangelogged patches". Because what the changelogs told
> us was utterly obvious from reading the patch.
>
> What the changelogs didn't tell us was _why_ the change was made. And
> guess what? I don't have a clue! I just haven't been following these
> kbuild minutea.
>
> Tracey, please send a description of *why* this change is being made
> and I'll add it to the changelogs. Please include that explanation in
> all such patches.
>
Is this good?
Changed Makefile to use <modules>-y instead of <modules>-objs because -objs is
deprecated and should now be switched. According to
(documentation/kbuild/makefiles.txt).
regards
td
On Nov 8, 2010, at 8:11 PM, Stephen Rothwell wrote:
...
> I have a quilt series in linux-next called aoe that has not been updated
> since Nov, 2009. Can I assume that it is defunct and remove it? Or will
> you be using it again?
You can remove it, thanks. When I created it, I had the
misunderstanding that I was supposed to push through
linux-next into Linus's tree. But patches still just go through
Andrew or Jens.
The aoe changes usually aren't invasive enough to benefit
from being available in linux-next, I think.
--
Ed Cashin
[email protected]
Hi Ed,
On Tue, 9 Nov 2010 08:54:55 -0500 Ed Cashin <[email protected]> wrote:
>
> On Nov 8, 2010, at 8:11 PM, Stephen Rothwell wrote:
> ...
> > I have a quilt series in linux-next called aoe that has not been updated
> > since Nov, 2009. Can I assume that it is defunct and remove it? Or will
> > you be using it again?
>
> You can remove it, thanks. When I created it, I had the
> misunderstanding that I was supposed to push through
> linux-next into Linus's tree. But patches still just go through
> Andrew or Jens.
>
> The aoe changes usually aren't invasive enough to benefit
> from being available in linux-next, I think.
OK, thanks, will do.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/