2010-11-22 16:00:01

by Roberto Sassu

[permalink] [raw]
Subject: [RFC][PATCH 2/4] fs: move file->f_cred initialization before security_file_alloc()

The initialization of the 'f_cred' field of the file descriptor structure
has been moved before calling the function security_file_alloc() in order
to allow LSM security modules to use such information.

Signed-off-by: Roberto Sassu <[email protected]>
---
fs/file_table.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/file_table.c b/fs/file_table.c
index fd446e3..78b9174 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -125,13 +125,13 @@ struct file *get_empty_filp(const struct cred *task_cred)
goto fail;

percpu_counter_inc(&nr_files);
+ f->f_cred = get_cred(cred);
if (security_file_alloc(f))
goto fail_sec;

INIT_LIST_HEAD(&f->f_u.fu_list);
atomic_long_set(&f->f_count, 1);
rwlock_init(&f->f_owner.lock);
- f->f_cred = get_cred(cred);
spin_lock_init(&f->f_lock);
eventpoll_init_file(f);
/* f->f_version: 0 */
--
1.7.2.3


Attachments:
smime.p7s (4.60 kB)