2010-12-01 13:05:13

by Namhyung Kim

Subject: [PATCH] Input: turbografx - fix reference counting

The ref-count of parport gained from parport_find_number()
was not released in normal path.

Signed-off-by: Namhyung Kim <[email protected]>
---
drivers/input/joystick/turbografx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
index d53b9e9..27b6a3c 100644
--- a/drivers/input/joystick/turbografx.c
+++ b/drivers/input/joystick/turbografx.c
@@ -245,6 +245,7 @@ static struct tgfx __init *tgfx_probe(int parport, int *n_buttons, int n_devs)
goto err_free_tgfx;
}

+ parport_put_port(pp);
return tgfx;

err_free_dev:
--
1.7.0.4

2010-12-01 17:21:23

by Dmitry Torokhov

Subject: Re: [PATCH] Input: turbografx - fix reference counting

On Wed, Dec 01, 2010 at 10:05:01PM +0900, Namhyung Kim wrote:
> The ref-count of parport gained from parport_find_number()
> was not released in normal path.
>

Applied, thanks.

> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> drivers/input/joystick/turbografx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
> index d53b9e9..27b6a3c 100644
> --- a/drivers/input/joystick/turbografx.c
> +++ b/drivers/input/joystick/turbografx.c
> @@ -245,6 +245,7 @@ static struct tgfx __init *tgfx_probe(int parport, int *n_buttons, int n_devs)
> goto err_free_tgfx;
> }
>
> + parport_put_port(pp);
> return tgfx;
>
> err_free_dev:
> --
> 1.7.0.4
>

--
Dmitry