2010-12-06 13:02:59

by Joe Jin

Subject: [patch 1/1] driver/net/benet: fix be_cmd_multicast_set() memcpy bug

Hi,

Regarding benet be_cmd_multicast_set() function, now using
netdev_for_each_mc_addr() helper for mac address copy, but
when copying to req->mac[] did not increase of the index.

Cc: Sathya Perla <[email protected]>
Cc: Subbu Seetharaman <[email protected]>
Cc: Sarveshwar Bandi <[email protected]>
Cc: Ajit Khaparde <[email protected]>
Signed-off-by: Joe Jin <[email protected]>

---
be_cmds.c | 2 +-

diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index 36eca1c..e4465d2 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -1235,7 +1235,7 @@ int be_cmd_multicast_set(struct be_adapter *adapter, u32 if_id,

i = 0;
netdev_for_each_mc_addr(ha, netdev)
- memcpy(req->mac[i].byte, ha->addr, ETH_ALEN);
+ memcpy(req->mac[i++].byte, ha->addr, ETH_ALEN);
} else {
req->promiscuous = 1;
}


--
Oracle <http://www.oracle.com>
Joe Jin | Team Leader, Software Development | +8610.8278.6295
ORACLE | Linux and Virtualization
Incubator Building 2-A ZPark | Beijing China, 100094

2010-12-08 18:27:04

by David Miller

Subject: Re: [patch 1/1] driver/net/benet: fix be_cmd_multicast_set() memcpy bug

From: Joe Jin <[email protected]>
Date: Mon, 6 Dec 2010 21:00:59 +0800

> Hi,
>
> Regarding benet be_cmd_multicast_set() function, now using
> netdev_for_each_mc_addr() helper for mac address copy, but
> when copying to req->mac[] did not increase of the index.
>
> Cc: Sathya Perla <[email protected]>
> Cc: Subbu Seetharaman <[email protected]>
> Cc: Sarveshwar Bandi <[email protected]>
> Cc: Ajit Khaparde <[email protected]>
> Signed-off-by: Joe Jin <[email protected]>

Applied, thank you.