2010-12-07 15:09:55

by Minchan Kim

[permalink] [raw]
Subject: [PATCH] memcg: Remove unnecessary return

Cc: Balbir Singh <[email protected]>
Cc: KAMEZAWA Hiroyuki <[email protected]>
Signed-off-by: Minchan Kim <[email protected]>
---
mm/memcontrol.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index f9435be..55f57e3 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -821,7 +821,6 @@ void mem_cgroup_del_lru_list(struct page *page, enum lru_list lru)
return;
VM_BUG_ON(list_empty(&pc->lru));
list_del_init(&pc->lru);
- return;
}

void mem_cgroup_del_lru(struct page *page)
--
1.7.0.4


2010-12-08 01:04:41

by Kamezawa Hiroyuki

[permalink] [raw]
Subject: Re: [PATCH] memcg: Remove unnecessary return

On Wed, 8 Dec 2010 00:09:40 +0900
Minchan Kim <[email protected]> wrote:

> Cc: Balbir Singh <[email protected]>
> Cc: KAMEZAWA Hiroyuki <[email protected]>
> Signed-off-by: Minchan Kim <[email protected]>

Acked-by: KAMEZAWA Hiroyuki <[email protected]>

2010-12-08 05:07:35

by Balbir Singh

[permalink] [raw]
Subject: Re: [PATCH] memcg: Remove unnecessary return

* MinChan Kim <[email protected]> [2010-12-08 00:09:40]:

> Cc: Balbir Singh <[email protected]>
> Cc: KAMEZAWA Hiroyuki <[email protected]>
> Signed-off-by: Minchan Kim <[email protected]>
> ---
> mm/memcontrol.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index f9435be..55f57e3 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -821,7 +821,6 @@ void mem_cgroup_del_lru_list(struct page *page, enum lru_list lru)
> return;
> VM_BUG_ON(list_empty(&pc->lru));
> list_del_init(&pc->lru);
> - return;
> }
>

Reviewed-by: Balbir Singh <[email protected]>

--
Three Cheers,
Balbir