2010-12-07 15:04:25

by Namhyung Kim

[permalink] [raw]
Subject: [PATCH] fujitsu-laptop: fix compiler warning on pnp_ids

Annotate pnp_ids as '__used' to fix following warning:

CC drivers/platform/x86/fujitsu-laptop.o
drivers/platform/x86/fujitsu-laptop.c:1243: warning: ‘pnp_ids’ defined but not used

Signed-off-by: Namhyung Kim <[email protected]>
---
drivers/platform/x86/fujitsu-laptop.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index f44cd26..ad88b2e 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -1240,7 +1240,7 @@ MODULE_ALIAS("dmi:*:svnFUJITSUSIEMENS:*:pvr:rvnFUJITSU:rnFJNB1D3:*:cvrS6410:*");
MODULE_ALIAS("dmi:*:svnFUJITSUSIEMENS:*:pvr:rvnFUJITSU:rnFJNB1E6:*:cvrS6420:*");
MODULE_ALIAS("dmi:*:svnFUJITSU:*:pvr:rvnFUJITSU:rnFJNB19C:*:cvrS7020:*");

-static struct pnp_device_id pnp_ids[] = {
+static struct pnp_device_id pnp_ids[] __used = {
{.id = "FUJ02bf"},
{.id = "FUJ02B1"},
{.id = "FUJ02E3"},
--
1.7.0.4


2010-12-07 22:34:49

by Jonathan Woithe

[permalink] [raw]
Subject: Re: [PATCH] fujitsu-laptop: fix compiler warning on pnp_ids

Looks fine to me.

Acked-by: Jonathan Woithe <[email protected]>

> Annotate pnp_ids as '__used' to fix following warning:
>
> CC drivers/platform/x86/fujitsu-laptop.o
> drivers/platform/x86/fujitsu-laptop.c:1243: warning: ‘pnp_ids’ defined but not used
>
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> drivers/platform/x86/fujitsu-laptop.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index f44cd26..ad88b2e 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -1240,7 +1240,7 @@ MODULE_ALIAS("dmi:*:svnFUJITSUSIEMENS:*:pvr:rvnFUJITSU:rnFJNB1D3:*:cvrS6410:*");
> MODULE_ALIAS("dmi:*:svnFUJITSUSIEMENS:*:pvr:rvnFUJITSU:rnFJNB1E6:*:cvrS6420:*");
> MODULE_ALIAS("dmi:*:svnFUJITSU:*:pvr:rvnFUJITSU:rnFJNB19C:*:cvrS7020:*");
>
> -static struct pnp_device_id pnp_ids[] = {
> +static struct pnp_device_id pnp_ids[] __used = {
> {.id = "FUJ02bf"},
> {.id = "FUJ02B1"},
> {.id = "FUJ02E3"},
> --
> 1.7.0.4