On Sat, Dec 11, 2010 at 8:19 PM, Jean Delvare <[email protected]> wrote:
> On Sat, 11 Dec 2010 17:51:37 +0100, Tejun Heo wrote:
>> flush_scheduled_work() is deprecated and scheduled to be removed.
>> Directly flush ams_info.worker on detach instead.
>
> The AMS driver is maintained by Stelian Pop and Michael Hanselmann
> according to MAINTAINERS. I am Cc'ing them both.
Change looks good to me, but can't test due to lack of hardware.
Michael
On Mon, 13 Dec 2010 11:16:38 +0100, Stelian Pop wrote:
> On Sun, Dec 12, 2010 at 02:37:28PM +0100, Michael Hanselmann wrote:
>
> > On Sat, Dec 11, 2010 at 8:19 PM, Jean Delvare <[email protected]> wrote:
> > > On Sat, 11 Dec 2010 17:51:37 +0100, Tejun Heo wrote:
> > >> flush_scheduled_work() is deprecated and scheduled to be removed.
> > >> Directly flush ams_info.worker on detach instead.
> > >
> > > The AMS driver is maintained by Stelian Pop and Michael Hanselmann
> > > according to MAINTAINERS. I am Cc'ing them both.
> >
> > Change looks good to me, but can't test due to lack of hardware.
>
> Same here. Looks like this driver can be orphaned...
If so, please submit a patch updating MAINTAINERS. Otherwise you'll
keep getting patches asking for your acknowledgment.
--
Jean Delvare
On Sun, Dec 12, 2010 at 02:37:28PM +0100, Michael Hanselmann wrote:
> On Sat, Dec 11, 2010 at 8:19 PM, Jean Delvare <[email protected]> wrote:
> > On Sat, 11 Dec 2010 17:51:37 +0100, Tejun Heo wrote:
> >> flush_scheduled_work() is deprecated and scheduled to be removed.
> >> Directly flush ams_info.worker on detach instead.
> >
> > The AMS driver is maintained by Stelian Pop and Michael Hanselmann
> > according to MAINTAINERS. I am Cc'ing them both.
>
> Change looks good to me, but can't test due to lack of hardware.
Same here. Looks like this driver can be orphaned...
Stelian.
--
Stelian Pop <[email protected]>
This driver is PPC only, and I can no longer test it.
Subject: [PATCH] Remove myself from MAINTAINERS as I no longer have the hardware to test.
Signed-off-by: Stelian Pop <[email protected]>
---
MAINTAINERS | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
On Mon, Dec 13, 2010 at 11:18:17AM +0100, Jean Delvare wrote:
> > > > The AMS driver is maintained by Stelian Pop and Michael Hanselmann
> > > > according to MAINTAINERS. I am Cc'ing them both.
> > >
> > > Change looks good to me, but can't test due to lack of hardware.
> >
> > Same here. Looks like this driver can be orphaned...
>
> If so, please submit a patch updating MAINTAINERS. Otherwise you'll
> keep getting patches asking for your acknowledgment.
Here it is.
I'll let Michael remove itself from MAINTAINERS and orphan the
driver if he no longer has any related hardware.
Thanks,
Stelian.
diff --git a/MAINTAINERS b/MAINTAINERS
index 1a1c27b..61d8c41 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -429,7 +429,6 @@ S: Supported
F: arch/x86/kernel/microcode_amd.c
AMS (Apple Motion Sensor) DRIVER
-M: Stelian Pop <[email protected]>
M: Michael Hanselmann <[email protected]>
S: Supported
F: drivers/macintosh/ams/
--
1.7.1
Hi Stelian,
On Mon, 13 Dec 2010 11:40:55 +0100, Stelian Pop wrote:
> This driver is PPC only, and I can no longer test it.
>
> Subject: [PATCH] Remove myself from MAINTAINERS as I no longer have the hardware to test.
>
> Signed-off-by: Stelian Pop <[email protected]>
> ---
> MAINTAINERS | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> (...)
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1a1c27b..61d8c41 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -429,7 +429,6 @@ S: Supported
> F: arch/x86/kernel/microcode_amd.c
>
> AMS (Apple Motion Sensor) DRIVER
> -M: Stelian Pop <[email protected]>
> M: Michael Hanselmann <[email protected]>
> S: Supported
> F: drivers/macintosh/ams/
I suggest that you send this patch to Andrew Morton or Benjamin
Herrenschmidt. It doesn't fit in any of my trees so I can't pick it.
Thanks,
--
Jean Delvare