2010-12-14 16:58:15

by Toralf Förster

Subject: [RESEND] [PATCH] kernel/panic.c: Fix two checkpatch.pl errors (whitespace cleanup)

nothing else

Signed-off-by: Toralf Förster <[email protected]>
---
kernel/panic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 4c13b1a..13623e4 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -56,7 +56,7 @@ EXPORT_SYMBOL(panic_blink);
*
* This function never returns.
*/
-NORET_TYPE void panic(const char * fmt, ...)
+NORET_TYPE void panic(const char *fmt, ...)
{
static char buf[1024];
va_list args;
@@ -75,7 +75,7 @@ NORET_TYPE void panic(const char * fmt, ...)
va_start(args, fmt);
vsnprintf(buf, sizeof(buf), fmt, args);
va_end(args);
- printk(KERN_EMERG "Kernel panic - not syncing: %s\n",buf);
+ printk(KERN_EMERG "Kernel panic - not syncing: %s\n", buf);
#ifdef CONFIG_DEBUG_BUGVERBOSE
dump_stack();
#endif
--
1.7.3.3

2010-12-14 18:43:15

by Dan Carpenter

Subject: Re: [RESEND] [PATCH] kernel/panic.c: Fix two checkpatch.pl errors (whitespace cleanup)

On Tue, Dec 14, 2010 at 05:58:08PM +0100, Toralf F?rster wrote:
> nothing else
>

This patch is not helpful. I mean that in the sense that the code is
just as readable before and after. :/ Please only send patches that
make the code better.

Checkpatch.pl is a good tool for staging but outside of staging you
should only use it for [check]ing [patch]es. The problem is that
pointless churn clutters up the log and breaks git blame. In staging
that's Ok.

regards,
dan carpenter

2010-12-14 18:50:31

by Toralf Förster

Subject: Re: [RESEND] [PATCH] kernel/panic.c: Fix two checkpatch.pl errors (whitespace cleanup)

Dan Carpenter wrote at 19:42:57
> The problem is that pointless churn clutters up the log and breaks git
blame.

Ok, understood.

--
MfG/Kind regards
Toralf F?rster

pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3