2010-12-20 17:23:19

by Carlos Mafra

[permalink] [raw]
Subject: Build regression: unknown option "visible"

After pulling latest git from Linus (v2.6.37-rc6-132-g55ec86f)
I can't compile it anymore:

[mafra@Pilar:linux-2.6]$ make -j2 O=/mnt/ext4/kernel-output/
GEN /mnt/ext4/kernel-output/Makefile
scripts/kconfig/conf --silentoldconfig Kconfig
drivers/i2c/algos/Kconfig:6: unknown option "visible"
drivers/media/common/tuners/Kconfig:48: unknown option "visible"
drivers/media/video/Kconfig:115: unknown option "visible"
drivers/media/dvb/frontends/Kconfig:16: unknown option "visible"
make[3]: *** [silentoldconfig] Fehler 1
make[2]: *** [silentoldconfig] Fehler 2

This was introduced by 37e3273ee52f ("media/video: convert Kconfig
to use the menu's `visible' keyword"), but I did a quick search
and apparently I am the only one with a broken build.

In any case, that's a regression for me and therefore I'm reporting it.

I can test patches etc and provide more info if needed.


2010-12-20 17:37:28

by Arnaud Lacombe

[permalink] [raw]
Subject: Re: Build regression: unknown option "visible"

Hi,

On Mon, Dec 20, 2010 at 12:22 PM, Carlos R. Mafra <[email protected]> wrote:
> After pulling latest git from Linus (v2.6.37-rc6-132-g55ec86f)
> I can't compile it anymore:
>
> [mafra@Pilar:linux-2.6]$ make -j2 O=/mnt/ext4/kernel-output/
> ?GEN ? ? /mnt/ext4/kernel-output/Makefile
> scripts/kconfig/conf --silentoldconfig Kconfig
> drivers/i2c/algos/Kconfig:6: unknown option "visible"
> drivers/media/common/tuners/Kconfig:48: unknown option "visible"
> drivers/media/video/Kconfig:115: unknown option "visible"
> drivers/media/dvb/frontends/Kconfig:16: unknown option "visible"
> make[3]: *** [silentoldconfig] Fehler 1
> make[2]: *** [silentoldconfig] Fehler 2
>
> This was introduced by 37e3273ee52f ("media/video: convert Kconfig
> to use the menu's `visible' keyword"), but I did a quick search
> and apparently I am the only one with a broken build.
>
> In any case, that's a regression for me and therefore I'm reporting it.
>
> I can test patches etc and provide more info if needed.
>
Did you build from a clean tree or a dirty one ?

I know these is issue with Kbuild where the parser will not get
updated to the new version if the target already exist but is older
than the current "shipped" one.

- Arnaud

2010-12-20 23:39:09

by Carlos Mafra

[permalink] [raw]
Subject: Re: Build regression: unknown option "visible"

On Mo 20.Dez'10 at 12:37:26 -0500, Arnaud Lacombe wrote:
> Hi,
>
> On Mon, Dec 20, 2010 at 12:22 PM, Carlos R. Mafra <[email protected]> wrote:
> > After pulling latest git from Linus (v2.6.37-rc6-132-g55ec86f)
> > I can't compile it anymore:
> >
> > [mafra@Pilar:linux-2.6]$ make -j2 O=/mnt/ext4/kernel-output/
> >  GEN     /mnt/ext4/kernel-output/Makefile
> > scripts/kconfig/conf --silentoldconfig Kconfig
> > drivers/i2c/algos/Kconfig:6: unknown option "visible"
> > drivers/media/common/tuners/Kconfig:48: unknown option "visible"
> > drivers/media/video/Kconfig:115: unknown option "visible"
> > drivers/media/dvb/frontends/Kconfig:16: unknown option "visible"
> > make[3]: *** [silentoldconfig] Fehler 1
> > make[2]: *** [silentoldconfig] Fehler 2
> >
> > This was introduced by 37e3273ee52f ("media/video: convert Kconfig
> > to use the menu's `visible' keyword"), but I did a quick search
> > and apparently I am the only one with a broken build.
> >
> > In any case, that's a regression for me and therefore I'm reporting it.
> >
> > I can test patches etc and provide more info if needed.
> >
> Did you build from a clean tree or a dirty one ?

It was the same one which I always compile after pulling.
So there is compiled stuff in the build dir /mnt/ext4/kernel-output
(in an external hd).

> I know these is issue with Kbuild where the parser will not get
> updated to the new version if the target already exist but is older
> than the current "shipped" one.

Hm, not sure what this means. Should I do a 'make clean' to get it
back working?

2010-12-20 23:41:34

by Arnaud Lacombe

[permalink] [raw]
Subject: Re: Build regression: unknown option "visible"

Hi,

On Mon, Dec 20, 2010 at 6:30 PM, Carlos R. Mafra <[email protected]> wrote:
> On Mo 20.Dez'10 at 12:37:26 -0500, Arnaud Lacombe wrote:
>> Hi,
>>
>> On Mon, Dec 20, 2010 at 12:22 PM, Carlos R. Mafra <[email protected]> wrote:
>> > After pulling latest git from Linus (v2.6.37-rc6-132-g55ec86f)
>> > I can't compile it anymore:
>> >
>> > [mafra@Pilar:linux-2.6]$ make -j2 O=/mnt/ext4/kernel-output/
>> > ?GEN ? ? /mnt/ext4/kernel-output/Makefile
>> > scripts/kconfig/conf --silentoldconfig Kconfig
>> > drivers/i2c/algos/Kconfig:6: unknown option "visible"
>> > drivers/media/common/tuners/Kconfig:48: unknown option "visible"
>> > drivers/media/video/Kconfig:115: unknown option "visible"
>> > drivers/media/dvb/frontends/Kconfig:16: unknown option "visible"
>> > make[3]: *** [silentoldconfig] Fehler 1
>> > make[2]: *** [silentoldconfig] Fehler 2
>> >
>> > This was introduced by 37e3273ee52f ("media/video: convert Kconfig
>> > to use the menu's `visible' keyword"), but I did a quick search
>> > and apparently I am the only one with a broken build.
>> >
>> > In any case, that's a regression for me and therefore I'm reporting it.
>> >
>> > I can test patches etc and provide more info if needed.
>> >
>> Did you build from a clean tree or a dirty one ?
>
> It was the same one which I always compile after pulling.
> So there is compiled stuff in the build dir /mnt/ext4/kernel-output
> (in an external hd).
>
>> I know these is issue with Kbuild where the parser will not get
>> updated to the new version if the target already exist but is older
>> than the current "shipped" one.
>
> Hm, not sure what this means. Should I do a 'make clean' to get it
> back working?
>
yes.

- Arnaud

2010-12-20 23:46:16

by Michal Marek

[permalink] [raw]
Subject: Re: Build regression: unknown option "visible"

On 20.12.2010 18:37, Arnaud Lacombe wrote:
> Hi,
>
> On Mon, Dec 20, 2010 at 12:22 PM, Carlos R. Mafra<[email protected]> wrote:
>> After pulling latest git from Linus (v2.6.37-rc6-132-g55ec86f)
>> I can't compile it anymore:
>>
>> [mafra@Pilar:linux-2.6]$ make -j2 O=/mnt/ext4/kernel-output/
>> GEN /mnt/ext4/kernel-output/Makefile
>> scripts/kconfig/conf --silentoldconfig Kconfig
>> drivers/i2c/algos/Kconfig:6: unknown option "visible"
>> drivers/media/common/tuners/Kconfig:48: unknown option "visible"
>> drivers/media/video/Kconfig:115: unknown option "visible"
>> drivers/media/dvb/frontends/Kconfig:16: unknown option "visible"
>> make[3]: *** [silentoldconfig] Fehler 1
>> make[2]: *** [silentoldconfig] Fehler 2
>>
>> This was introduced by 37e3273ee52f ("media/video: convert Kconfig
>> to use the menu's `visible' keyword"), but I did a quick search
>> and apparently I am the only one with a broken build.
>>
>> In any case, that's a regression for me and therefore I'm reporting it.
>>
>> I can test patches etc and provide more info if needed.
>>
> Did you build from a clean tree or a dirty one ?
>
> I know these is issue with Kbuild where the parser will not get
> updated to the new version if the target already exist but is older
> than the current "shipped" one.

Yes, if you build kconfig in the source tree and then do another build
in a separate directory (make O=/some/where), the build system will not
detect this and happily use generated kconfig files from the previous
build attempt. I really should fix this given the pace of kconfig
development lately :-).

Michal

2010-12-21 00:32:37

by Carlos Mafra

[permalink] [raw]
Subject: Re: Build regression: unknown option "visible"

On Mo 20.Dez'10 at 18:41:32 -0500, Arnaud Lacombe wrote:
> Hi,
>
> On Mon, Dec 20, 2010 at 6:30 PM, Carlos R. Mafra <[email protected]> wrote:

> > Should I do a 'make clean' to get it back working?
> >
> yes.

Ah, it works now. Sorry about the noise.