2010-12-21 10:10:00

by Stefan Schmidt

Subject: [PATCH] block/cciss: Close continue statement with semicolon to fix build

This fixes the following build error:
drivers/block/cciss.c: In function ‘cciss_revalidate’:
drivers/block/cciss.c:2839: error: expected ‘;’ before ‘if’
make[2]: *** [drivers/block/cciss.o] Error 1

Signed-off-by: Stefan Schmidt <[email protected]>
---
drivers/block/cciss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 233e06c..8e0f925 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -2835,7 +2835,7 @@ static int cciss_revalidate(struct gendisk *disk)

for (logvol = 0; logvol < CISS_MAX_LUN; logvol++) {
if (!h->drv[logvol])
- continue
+ continue;
if (memcmp(h->drv[logvol]->LunID, drv->LunID,
sizeof(drv->LunID)) == 0) {
FOUND = 1;
--
1.7.2.3

2010-12-21 10:10:26

by Jens Axboe

Subject: Re: [PATCH] block/cciss: Close continue statement with semicolon to fix build

On 2010-12-21 10:42, Stefan Schmidt wrote:
> This fixes the following build error:
> drivers/block/cciss.c: In function ‘cciss_revalidate’:
> drivers/block/cciss.c:2839: error: expected ‘;’ before ‘if’
> make[2]: *** [drivers/block/cciss.o] Error 1

It's already included in Linus' git.

--
Jens Axboe

2010-12-21 10:31:09

by Stefan Schmidt

Subject: Re: [PATCH] block/cciss: Close continue statement with semicolon to fix build

Hello.

On Tue, 2010-12-21 at 11:09, Jens Axboe wrote:
> On 2010-12-21 10:42, Stefan Schmidt wrote:
> > This fixes the following build error:
> > drivers/block/cciss.c: In function ‘cciss_revalidate’:
> > drivers/block/cciss.c:2839: error: expected ‘;’ before ‘if’
> > make[2]: *** [drivers/block/cciss.o] Error 1
>
> It's already included in Linus' git.

Hmm, not on my latest pull. And git tells me I'm up-to-date.

commit 8cad7f06e3b1d3f9a28bb7385e8fc09d5e1bf84c
Merge: 92d7c9b 0e4d413
Author: Linus Torvalds <[email protected]>
Date: Mon Dec 20 10:35:04 2010 -0800

Merge branch 'v4l_for_linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6

Webfrontend tells me the same.

So it is either not mirrored out yet or something else is spuky.

regards
Stefan Schmidt

2010-12-21 10:33:14

by Jens Axboe

Subject: Re: [PATCH] block/cciss: Close continue statement with semicolon to fix build

On 2010-12-21 11:31, Stefan Schmidt wrote:
> Hello.
>
> On Tue, 2010-12-21 at 11:09, Jens Axboe wrote:
>> On 2010-12-21 10:42, Stefan Schmidt wrote:
>>> This fixes the following build error:
>>> drivers/block/cciss.c: In function ‘cciss_revalidate’:
>>> drivers/block/cciss.c:2839: error: expected ‘;’ before ‘if’
>>> make[2]: *** [drivers/block/cciss.o] Error 1
>>
>> It's already included in Linus' git.
>
> Hmm, not on my latest pull. And git tells me I'm up-to-date.
>
> commit 8cad7f06e3b1d3f9a28bb7385e8fc09d5e1bf84c
> Merge: 92d7c9b 0e4d413
> Author: Linus Torvalds <[email protected]>
> Date: Mon Dec 20 10:35:04 2010 -0800
>
> Merge branch 'v4l_for_linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6
>
> Webfrontend tells me the same.
>
> So it is either not mirrored out yet or something else is spuky.

Latest head is:

commit e5fcdb7ed856b714c878ad470040fe832cbe462b
Merge: 7bddaac 093d804
Author: Linus Torvalds <[email protected]>

And the fix is commit 453434cf3fdcd3954bb52460e37d4945a0913d3e. Perhaps
the mirror is slow, dunno, I pull via ssh from master.

--
Jens Axboe

2010-12-21 10:39:55

by Stefan Schmidt

Subject: Re: [PATCH] block/cciss: Close continue statement with semicolon to fix build

Hello.

On Tue, 2010-12-21 at 11:32, Jens Axboe wrote:
> On 2010-12-21 11:31, Stefan Schmidt wrote:
>
> Latest head is:
>
> commit e5fcdb7ed856b714c878ad470040fe832cbe462b
> Merge: 7bddaac 093d804
> Author: Linus Torvalds <[email protected]>
>
> And the fix is commit 453434cf3fdcd3954bb52460e37d4945a0913d3e. Perhaps
> the mirror is slow, dunno, I pull via ssh from master.

The mirroring seems to be the problem then. Public tree is behind and thats why
it is not fixed for me. Just ignore the patch then. :)

regards
Stefan Schmidt